OpenCloud
/
riot-web
mirror of https://github.com/vector-im/riot-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Merge pull request #5021 from matrix-org/t3chguy/room-list/14631 

Tag Watcher don't create new filter if not needed, confuses references
pull/21833/head
Travis Ralston 2020-07-20 15:13:09 -06:00 committed by GitHub
parent e0ac956442 29defa3e57
commit 4de1645ac7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/stores/room-list/TagWatcher.ts
View File

@ -54,7 +54,11 @@ export class TagWatcher {
continue; continue;
} }
newFilters.set(tag, new CommunityFilterCondition(group)); let filter = this.filters.get(tag);
if (!filter) {
filter = new CommunityFilterCondition(group);
}
newFilters.set(tag, filter);
} }
// Update the room list store's filters // Update the room list store's filters
@ -73,10 +77,6 @@ export class TagWatcher {
if (!filter) continue; if (!filter) continue;
this.store.removeFilter(filter); this.store.removeFilter(filter);
}
// Destroy any and all old filter conditions to prevent resource leaks
for (const filter of this.filters.values()) {
filter.destroy(); filter.destroy();
} }