From 4f71f4c331bb36d19ccdd92d2d92425bc7cf3138 Mon Sep 17 00:00:00 2001
From: Luke Barnard <lukeb@openmarket.com>
Date: Tue, 2 May 2017 10:07:06 +0100
Subject: [PATCH] Store mx_pass at the same point as access_token

So that we don't overwrite the existing one every time we try to register.
---
 src/Lifecycle.js                              |  6 ++++++
 src/components/views/dialogs/SetMxIdDialog.js | 12 +++++-------
 2 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/src/Lifecycle.js b/src/Lifecycle.js
index f20716cae6..7fba0a0298 100644
--- a/src/Lifecycle.js
+++ b/src/Lifecycle.js
@@ -303,6 +303,12 @@ export function setLoggedIn(credentials) {
                 localStorage.setItem("mx_device_id", credentials.deviceId);
             }
 
+            // The user registered as a PWLU (PassWord-Less User), the generated password
+            // is cached here such that the user can change it at a later time.
+            if (credentials.password) {
+                localStorage.setItem("mx_pass", credentials.password);
+            }
+
             console.log("Session persisted for %s", credentials.userId);
         } catch (e) {
             console.warn("Error using local storage: can't persist session!", e);
diff --git a/src/components/views/dialogs/SetMxIdDialog.js b/src/components/views/dialogs/SetMxIdDialog.js
index c8083371de..db88c3304b 100644
--- a/src/components/views/dialogs/SetMxIdDialog.js
+++ b/src/components/views/dialogs/SetMxIdDialog.js
@@ -56,21 +56,18 @@ export default React.createClass({
         });
     },
 
-    _generateAndCachePassword: function() {
-        const pass = Math.random().toString(36).slice(2);
-        if (localStorage) {
-            localStorage.setItem('mx_pass', pass);
-        }
-        return pass;
+    _generatePassword: function() {
+        return Math.random().toString(36).slice(2);
     },
 
     _makeRegisterRequest: function(auth) {
         // Not upgrading - changing mxids
         const guestAccessToken = null;
+        this._generatedPassword = this._generatePassword();
 
         return this._matrixClient.register(
             this.state.username,
-            this._generateAndCachePassword(),
+            this._generatedPassword,
             undefined, // session id: included in the auth dict already
             auth,
             {},
@@ -98,6 +95,7 @@ export default React.createClass({
             homeserverUrl: this._matrixClient.getHomeserverUrl(),
             identityServerUrl: this._matrixClient.getIdentityServerUrl(),
             accessToken: response.access_token,
+            password: this._generatedPassword,
             teamToken: teamToken,
         });
     },