OpenCloud
/
riot-web
mirror of https://github.com/vector-im/riot-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Merge pull request #5372 from matrix-org/t3chguy/countly 

Only pass metrics if they exist otherwise Countly will be unhappy!
pull/21833/head
Michael Telatynski 2020-10-30 16:24:28 +00:00 committed by GitHub
parent f80ee391bc 067886f5e8
commit 517e3b5ea4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/CountlyAnalytics.ts
View File

@ -525,9 +525,9 @@ export default class CountlyAnalytics {
const metrics = this.getMetrics();
const ob: ICrash = {
_resolution: metrics._resolution,
_resolution: metrics?._resolution,
_error: error,
_app_version: metrics._app_version,
_app_version: this.appVersion,
_run: CountlyAnalytics.getTimestamp() - this.initTime,
_nonfatal: !fatal,
_view: this.lastView,
@ -729,11 +729,17 @@ export default class CountlyAnalytics {
},
};
await this.request({
const request: Parameters<typeof CountlyAnalytics.prototype.request>[0] = {
begin_session: 1,
metrics: JSON.stringify(this.getMetrics()),
user_details: JSON.stringify(userDetails),
});
}
const metrics = this.getMetrics();
if (metrics) {
request.metrics = JSON.stringify(metrics);
}
await this.request(request);
}
}