Fix ResizeHandle of the third pinned widget (#10896)

* Revert "Remove unused prop from ResizeHandle - reverse (#10771)"

This reverts commit 62569e209e.

* Add a comment
pull/28788/head^2
Suguru Hirahara 2023-05-15 07:40:15 +00:00 committed by GitHub
parent 70b67fca77
commit 5988bb9a68
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 2 deletions

View File

@ -265,6 +265,7 @@ class LoggedInView extends React.Component<IProps, IState> {
resizer.setClassNames({ resizer.setClassNames({
handle: "mx_ResizeHandle", handle: "mx_ResizeHandle",
vertical: "mx_ResizeHandle--vertical", vertical: "mx_ResizeHandle--vertical",
reverse: "mx_ResizeHandle_reverse",
}); });
return resizer; return resizer;
} }

View File

@ -19,17 +19,21 @@ import React from "react"; // eslint-disable-line no-unused-vars
//see src/resizer for the actual resizing code, this is just the DOM for the resize handle //see src/resizer for the actual resizing code, this is just the DOM for the resize handle
interface IResizeHandleProps { interface IResizeHandleProps {
vertical?: boolean; vertical?: boolean;
reverse?: boolean;
id?: string; id?: string;
passRef?: React.RefObject<HTMLDivElement>; passRef?: React.RefObject<HTMLDivElement>;
} }
const ResizeHandle: React.FC<IResizeHandleProps> = ({ vertical, id, passRef }) => { const ResizeHandle: React.FC<IResizeHandleProps> = ({ vertical, reverse, id, passRef }) => {
const classNames = ["mx_ResizeHandle"]; const classNames = ["mx_ResizeHandle"];
if (vertical) { if (vertical) {
classNames.push("mx_ResizeHandle--vertical"); classNames.push("mx_ResizeHandle--vertical");
} else { } else {
classNames.push("mx_ResizeHandle--horizontal"); classNames.push("mx_ResizeHandle--horizontal");
} }
if (reverse) {
classNames.push("mx_ResizeHandle_reverse"); // required for the resizer of the third pinned widget to work
}
return ( return (
<div ref={passRef} className={classNames.join(" ")} data-id={id}> <div ref={passRef} className={classNames.join(" ")} data-id={id}>
<div /> <div />

View File

@ -110,6 +110,7 @@ export default class AppsDrawer extends React.Component<IProps, IState> {
const classNames = { const classNames = {
handle: "mx_ResizeHandle", handle: "mx_ResizeHandle",
vertical: "mx_ResizeHandle--vertical", vertical: "mx_ResizeHandle--vertical",
reverse: "mx_ResizeHandle_reverse",
}; };
const collapseConfig = { const collapseConfig = {
onResizeStart: () => { onResizeStart: () => {
@ -265,7 +266,7 @@ export default class AppsDrawer extends React.Component<IProps, IState> {
if (i < 1) return app; if (i < 1) return app;
return ( return (
<React.Fragment key={app.key}> <React.Fragment key={app.key}>
<ResizeHandle /> <ResizeHandle reverse={i > apps.length / 2} />
{app} {app}
</React.Fragment> </React.Fragment>
); );