From 5e6367ab5718ee8f17f0e12ee4de2f61853a6e3f Mon Sep 17 00:00:00 2001
From: Bruno Windels <brunow@matrix.org>
Date: Thu, 9 May 2019 15:42:10 +0200
Subject: [PATCH] basic support for non-editable parts

e.g. pills, they get deleted when any character of them is removed
later on we also shouldn't allow the caret to be set inside of them
---
 src/editor/model.js | 41 ++++++++++++++++++++++-------------------
 src/editor/parts.js |  8 ++++++++
 2 files changed, 30 insertions(+), 19 deletions(-)

diff --git a/src/editor/model.js b/src/editor/model.js
index 2bf78026b3..6834d31c4d 100644
--- a/src/editor/model.js
+++ b/src/editor/model.js
@@ -20,7 +20,6 @@ export default class EditorModel {
     constructor(parts, partCreator) {
         this._parts = parts;
         this._partCreator = partCreator;
-        this._previousValue = parts.reduce((text, p) => text + p.text, "");
         this._activePartIdx = null;
         this._autoComplete = null;
         this._autoCompletePartIdx = null;
@@ -68,19 +67,19 @@ export default class EditorModel {
     _diff(newValue, inputType, caret) {
         // handle deleteContentForward (Delete key)
         // and deleteContentBackward (Backspace)
-
+        const previousValue = this.parts.reduce((text, p) => text + p.text, "");
         // can't use caret position with drag and drop
         if (inputType === "deleteByDrag") {
-            return diffDeletion(this._previousValue, newValue);
+            return diffDeletion(previousValue, newValue);
         } else {
-            return diffAtCaret(this._previousValue, newValue, caret.offset);
+            return diffAtCaret(previousValue, newValue, caret.offset);
         }
     }
 
     update(newValue, inputType, caret) {
         const diff = this._diff(newValue, inputType, caret);
         const position = this._positionForOffset(diff.at, caret.atNodeEnd);
-        console.log("update at", {position, diff, newValue, prevValue: this._previousValue});
+        console.log("update at", {position, diff, newValue, prevValue: this.parts.reduce((text, p) => text + p.text, "")});
         if (diff.removed) {
             this._removeText(position, diff.removed.length);
         }
@@ -88,7 +87,6 @@ export default class EditorModel {
             this._addText(position, diff.added);
         }
         this._mergeAdjacentParts();
-        this._previousValue = newValue;
         const caretOffset = diff.at + (diff.added ? diff.added.length : 0);
         const newPosition = this._positionForOffset(caretOffset, true);
         this._setActivePart(newPosition);
@@ -141,23 +139,28 @@ export default class EditorModel {
 
     _removeText(pos, len) {
         let {index, offset} = pos;
-        while (len !== 0) {
+        while (len > 0) {
             // part might be undefined here
             let part = this._parts[index];
-            const amount = Math.min(len, part.text.length - offset);
-            const replaceWith = part.remove(offset, amount);
-            if (typeof replaceWith === "string") {
-                this._replacePart(index, this._partCreator.createDefaultPart(replaceWith));
-            }
-            part = this._parts[index];
-            // remove empty part
-            if (!part.text.length) {
-                this._removePart(index);
+            if (part.canEdit) {
+                const amount = Math.min(len, part.text.length - offset);
+                const replaceWith = part.remove(offset, amount);
+                if (typeof replaceWith === "string") {
+                    this._replacePart(index, this._partCreator.createDefaultPart(replaceWith));
+                }
+                part = this._parts[index];
+                // remove empty part
+                if (!part.text.length) {
+                    this._removePart(index);
+                } else {
+                    index += 1;
+                }
+                len -= amount;
+                offset = 0;
             } else {
-                index += 1;
+                len = part.length - (offset + len);
+                this._removePart(index);
             }
-            len -= amount;
-            offset = 0;
         }
     }
 
diff --git a/src/editor/parts.js b/src/editor/parts.js
index e060be716e..619bdfba9b 100644
--- a/src/editor/parts.js
+++ b/src/editor/parts.js
@@ -91,6 +91,10 @@ class BasePart {
     get text() {
         return this._text;
     }
+
+    get canEdit() {
+        return true;
+    }
 }
 
 export class PlainPart extends BasePart {
@@ -165,6 +169,10 @@ class PillPart extends BasePart {
                node.childNodes.length === 1 &&
                node.childNodes[0].nodeType === Node.TEXT_NODE;
     }
+
+    get canEdit() {
+        return false;
+    }
 }
 
 export class RoomPillPart extends PillPart {