OpenCloud
/
riot-web
mirror of https://github.com/vector-im/riot-web
1
0
Fork 0
Code Issues Releases Wiki Activity

[Backport staging] use correct default for notification silencing (#9389) 

Co-authored-by: Kerry <kerrya@element.io>
pull/28788/head^2
ElementRobot 2022-10-11 17:27:36 +01:00 committed by GitHub
parent 9dc82fb486
commit 67cae5fe45
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/utils/notifications.ts
View File

@ -25,5 +25,5 @@ export function getLocalNotificationAccountDataEventType(deviceId: string): stri
export function localNotificationsAreSilenced(cli: MatrixClient): boolean { export function localNotificationsAreSilenced(cli: MatrixClient): boolean {
const eventType = getLocalNotificationAccountDataEventType(cli.deviceId); const eventType = getLocalNotificationAccountDataEventType(cli.deviceId);
const event = cli.getAccountData(eventType); const event = cli.getAccountData(eventType);
return event?.getContent<LocalNotificationSettings>()?.is_silenced ?? true; return event?.getContent<LocalNotificationSettings>()?.is_silenced ?? false;
} }

4
test/utils/notifications-test.ts
View File

@ -47,8 +47,8 @@ describe('notifications', () => {
}); });
describe('localNotificationsAreSilenced', () => { describe('localNotificationsAreSilenced', () => {
it('defaults to true when no setting exists', () => { it('defaults to false when no setting exists', () => {
expect(localNotificationsAreSilenced(mockClient)).toBeTruthy(); expect(localNotificationsAreSilenced(mockClient)).toBeFalsy();
}); });
it('checks the persisted value', () => { it('checks the persisted value', () => {
mockClient.setAccountData(accountDataEventKey, { is_silenced: true }); mockClient.setAccountData(accountDataEventKey, { is_silenced: true });