OpenCloud
/
riot-web
mirror of https://github.com/vector-im/riot-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Avoid a reflow when setting caret position on an empty composer (#8348) 

This saves an extra ~12 ms on each room switch, because we can.
pull/28217/head
Robin 2022-04-17 09:45:34 -04:00 committed by GitHub
parent 2234f04332
commit 741b13ab6f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/editor/caret.ts
View File

@ -43,6 +43,8 @@ function setDocumentRangeSelection(editor: HTMLDivElement, model: EditorModel, r
} }
export function setCaretPosition(editor: HTMLDivElement, model: EditorModel, caretPosition: IPosition) { export function setCaretPosition(editor: HTMLDivElement, model: EditorModel, caretPosition: IPosition) {
if (model.isEmpty) return; // selection can't possibly be wrong, so avoid a reflow
const range = document.createRange(); const range = document.createRange();
const { node, offset } = getNodeAndOffsetForPosition(editor, model, caretPosition); const { node, offset } = getNodeAndOffsetForPosition(editor, model, caretPosition);
range.setStart(node, offset); range.setStart(node, offset);