OpenCloud
/
riot-web
mirror of https://github.com/vector-im/riot-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Null-guard ELS from null summaryMembers (#7744)

pull/21833/head
Michael Telatynski 2022-02-08 14:26:26 +00:00 committed by GitHub
parent ed185240a5
commit 760446c087
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/components/views/elements/EventListSummary.tsx
View File

@ -18,6 +18,7 @@ import React, { ReactNode, useEffect } from "react";
import { uniqBy } from "lodash"; import { uniqBy } from "lodash";
import { MatrixEvent } from "matrix-js-sdk/src/models/event"; import { MatrixEvent } from "matrix-js-sdk/src/models/event";
import { RoomMember } from "matrix-js-sdk/src/models/room-member"; import { RoomMember } from "matrix-js-sdk/src/models/room-member";
import { logger } from "matrix-js-sdk/src/logger";
import MemberAvatar from '../avatars/MemberAvatar'; import MemberAvatar from '../avatars/MemberAvatar';
import { _t } from '../../../languageHandler'; import { _t } from '../../../languageHandler';
@ -81,7 +82,14 @@ const EventListSummary: React.FC<IProps> = ({
{ children } { children }
</React.Fragment>; </React.Fragment>;
} else { } else {
const uniqueMembers = uniqBy(summaryMembers, member => member.getMxcAvatarUrl()); const uniqueMembers = uniqBy(summaryMembers.filter(member => {
if (!member?.getMxcAvatarUrl) {
logger.error("EventListSummary given null summaryMember, termites may be afoot eating event senders",
summaryMembers);
return false;
}
return true;
}), member => member.getMxcAvatarUrl());
const avatars = uniqueMembers.map((m) => <MemberAvatar key={m.userId} member={m} width={14} height={14} />); const avatars = uniqueMembers.map((m) => <MemberAvatar key={m.userId} member={m} width={14} height={14} />);
body = ( body = (
<div className="mx_EventTile_line"> <div className="mx_EventTile_line">