From 7638790095f8f033a8c72627180dd4c589892917 Mon Sep 17 00:00:00 2001 From: Michael Telatynski <7t3chguy@gmail.com> Date: Mon, 4 Dec 2023 13:41:20 +0000 Subject: [PATCH] Migrate pills-click-in-app.spec.ts from Cypress to Playwright (#11984) Co-authored-by: R Midhun Suresh --- .../pills-click-in-app.spec.ts | 77 ------------------- .../pills-click-in-app.spec.ts | 60 +++++++++++++++ 2 files changed, 60 insertions(+), 77 deletions(-) delete mode 100644 cypress/e2e/regression-tests/pills-click-in-app.spec.ts create mode 100644 playwright/e2e/regression-tests/pills-click-in-app.spec.ts diff --git a/cypress/e2e/regression-tests/pills-click-in-app.spec.ts b/cypress/e2e/regression-tests/pills-click-in-app.spec.ts deleted file mode 100644 index f8e607a4f2..0000000000 --- a/cypress/e2e/regression-tests/pills-click-in-app.spec.ts +++ /dev/null @@ -1,77 +0,0 @@ -/* -Copyright 2022 The Matrix.org Foundation C.I.C. - -Licensed under the Apache License, Version 2.0 (the "License"); -you may not use this file except in compliance with the License. -You may obtain a copy of the License at - - http://www.apache.org/licenses/LICENSE-2.0 - -Unless required by applicable law or agreed to in writing, software -distributed under the License is distributed on an "AS IS" BASIS, -WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -See the License for the specific language governing permissions and -limitations under the License. -*/ - -/// - -import { HomeserverInstance } from "../../plugins/utils/homeserver"; - -describe("Pills", () => { - let homeserver: HomeserverInstance; - - beforeEach(() => { - cy.startHomeserver("default").then((data) => { - homeserver = data; - - cy.initTestUser(homeserver, "Sally"); - }); - }); - - afterEach(() => { - cy.stopHomeserver(homeserver); - }); - - it("should navigate clicks internally to the app", () => { - const messageRoom = "Send Messages Here"; - const targetLocalpart = "aliasssssssssssss"; - cy.createRoom({ - name: "Target", - room_alias_name: targetLocalpart, - }).as("targetRoomId"); - cy.createRoom({ - name: messageRoom, - }).as("messageRoomId"); - cy.all([cy.get("@targetRoomId"), cy.get("@messageRoomId")]).then( - ([targetRoomId, messageRoomId]) => { - // discard the target room ID - we don't need it - cy.viewRoomByName(messageRoom); - cy.url().should("contain", `/#/room/${messageRoomId}`); - - // send a message using the built-in room mention functionality (autocomplete) - cy.findByRole("textbox", { name: "Send a message…" }).type( - `Hello world! Join here: #${targetLocalpart.substring(0, 3)}`, - ); - cy.get(".mx_Autocomplete_Completion_title").click(); - cy.findByRole("button", { name: "Send message" }).click(); - - // find the pill in the timeline and click it - cy.get(".mx_EventTile_body .mx_Pill").click(); - - const localUrl = `/#/room/#${targetLocalpart}:`; - // verify we landed at a sane place - cy.url().should("contain", localUrl); - - cy.wait(250); // let the room list settle - - // go back to the message room and try to click on the pill text, as a user would - cy.viewRoomByName(messageRoom); - cy.get(".mx_EventTile_body .mx_Pill .mx_Pill_text") - .should("have.css", "pointer-events", "none") - .click({ force: true }); // force is to ensure we bypass pointer-events - cy.url().should("contain", localUrl); - }, - ); - }); -}); diff --git a/playwright/e2e/regression-tests/pills-click-in-app.spec.ts b/playwright/e2e/regression-tests/pills-click-in-app.spec.ts new file mode 100644 index 0000000000..6a038db43d --- /dev/null +++ b/playwright/e2e/regression-tests/pills-click-in-app.spec.ts @@ -0,0 +1,60 @@ +/* +Copyright 2022 The Matrix.org Foundation C.I.C. + +Licensed under the Apache License, Version 2.0 (the "License"); +you may not use this file except in compliance with the License. +You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + +Unless required by applicable law or agreed to in writing, software +distributed under the License is distributed on an "AS IS" BASIS, +WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +See the License for the specific language governing permissions and +limitations under the License. +*/ + +import { test, expect } from "../../element-web-test"; + +test.describe("Pills", () => { + test.use({ + displayName: "Sally", + }); + + test("should navigate clicks internally to the app", async ({ page, app, user }) => { + const messageRoom = "Send Messages Here"; + const targetLocalpart = "aliasssssssssssss"; + await app.client.createRoom({ + name: "Target", + room_alias_name: targetLocalpart, + }); + const messageRoomId = await app.client.createRoom({ + name: messageRoom, + }); + + await app.viewRoomByName(messageRoom); + await expect(page).toHaveURL(new RegExp(`/#/room/${messageRoomId}`)); + + // send a message using the built-in room mention functionality (autocomplete) + await page + .getByRole("textbox", { name: "Send a message…" }) + .pressSequentially(`Hello world! Join here: #${targetLocalpart.substring(0, 3)}`); + await page.locator(".mx_Autocomplete_Completion_title").click(); + await page.getByRole("button", { name: "Send message" }).click(); + + // find the pill in the timeline and click it + await page.locator(".mx_EventTile_body .mx_Pill").click(); + + const localUrl = new RegExp(`/#/room/#${targetLocalpart}:`); + // verify we landed at a sane place + await expect(page).toHaveURL(localUrl); + + // go back to the message room and try to click on the pill text, as a user would + await app.viewRoomByName(messageRoom); + const pillText = page.locator(".mx_EventTile_body .mx_Pill .mx_Pill_text"); + await expect(pillText).toHaveCSS("pointer-events", "none"); + await pillText.click({ force: true }); // force is to ensure we bypass pointer-events + + await expect(page).toHaveURL(localUrl); + }); +});