mirror of https://github.com/vector-im/riot-web
App tile permissions -- broken
parent
bcd1ab5cd4
commit
76f4f88fcd
|
@ -0,0 +1,43 @@
|
||||||
|
import React from 'react';
|
||||||
|
import PropTypes from 'prop-types';
|
||||||
|
import { URL, URLSearchParams } from 'url';
|
||||||
|
|
||||||
|
export default class AppPermission extends React.Component {
|
||||||
|
constructor(props) {
|
||||||
|
super(props);
|
||||||
|
|
||||||
|
this.state = {
|
||||||
|
curl: this.getCurl(),
|
||||||
|
};
|
||||||
|
}
|
||||||
|
|
||||||
|
getCurl() {
|
||||||
|
let wurl = URL.parse(this.props.url);
|
||||||
|
console.log('wurl', wurl);
|
||||||
|
if(wurl.searchParams.get('url')) {
|
||||||
|
let curl = wurl.searchParams.get('url');
|
||||||
|
console.log('curl', curl);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
render() {
|
||||||
|
return (
|
||||||
|
<div>
|
||||||
|
Load widget with URL : {this.state.cUrl}
|
||||||
|
<input
|
||||||
|
type='button'
|
||||||
|
value='Allow'
|
||||||
|
onClick={this.props.onPermissionGranted}
|
||||||
|
/>
|
||||||
|
</div>
|
||||||
|
);
|
||||||
|
}
|
||||||
|
}
|
||||||
|
|
||||||
|
AppPermission.propTypes = {
|
||||||
|
url: PropTypes.string.isRequired,
|
||||||
|
onPermissionGranted: PropTypes.func.isRequired,
|
||||||
|
};
|
||||||
|
AppPermission.defaultPropTypes = {
|
||||||
|
onPermissionGranted: function() {},
|
||||||
|
};
|
|
@ -24,6 +24,7 @@ import SdkConfig from '../../../SdkConfig';
|
||||||
import Modal from '../../../Modal';
|
import Modal from '../../../Modal';
|
||||||
import { _t } from '../../../languageHandler';
|
import { _t } from '../../../languageHandler';
|
||||||
import sdk from '../../../index';
|
import sdk from '../../../index';
|
||||||
|
import AppPermission from './AppPermission';
|
||||||
|
|
||||||
const ALLOWED_APP_URL_SCHEMES = ['https:', 'http:'];
|
const ALLOWED_APP_URL_SCHEMES = ['https:', 'http:'];
|
||||||
const betaHelpMsg = 'This feature is currently experimental and is intended for beta testing only';
|
const betaHelpMsg = 'This feature is currently experimental and is intended for beta testing only';
|
||||||
|
@ -46,9 +47,12 @@ export default React.createClass({
|
||||||
},
|
},
|
||||||
|
|
||||||
getInitialState: function() {
|
getInitialState: function() {
|
||||||
|
const widgetPermissionId = [this.props.room.roomId, encodeURIComponent(this.props.url)].join('_');
|
||||||
return {
|
return {
|
||||||
loading: false,
|
loading: false,
|
||||||
widgetUrl: this.props.url,
|
widgetUrl: this.props.url,
|
||||||
|
widgetPermissionId: widgetPermissionId,
|
||||||
|
hasPermissionToLoad: localStorage.getItem(widgetPermissionId),
|
||||||
error: null,
|
error: null,
|
||||||
deleting: false,
|
deleting: false,
|
||||||
};
|
};
|
||||||
|
@ -116,6 +120,11 @@ export default React.createClass({
|
||||||
});
|
});
|
||||||
},
|
},
|
||||||
|
|
||||||
|
_grantWidgetPermission() {
|
||||||
|
console.warn('Granting permission to load widget - ', this.state.widgetUrl);
|
||||||
|
localStorage.setItem(this.state.widgetPermissionId, true);
|
||||||
|
},
|
||||||
|
|
||||||
formatAppTileName: function() {
|
formatAppTileName: function() {
|
||||||
let appTileName = "No name";
|
let appTileName = "No name";
|
||||||
if(this.props.name && this.props.name.trim()) {
|
if(this.props.name && this.props.name.trim()) {
|
||||||
|
@ -133,11 +142,6 @@ export default React.createClass({
|
||||||
return <div></div>;
|
return <div></div>;
|
||||||
}
|
}
|
||||||
|
|
||||||
if (this.state.loading) {
|
|
||||||
appTileBody = (
|
|
||||||
<div> Loading... </div>
|
|
||||||
);
|
|
||||||
} else {
|
|
||||||
// Note that there is advice saying allow-scripts shouldn't be used with allow-same-origin
|
// Note that there is advice saying allow-scripts shouldn't be used with allow-same-origin
|
||||||
// because that would allow the iframe to prgramatically remove the sandbox attribute, but
|
// because that would allow the iframe to prgramatically remove the sandbox attribute, but
|
||||||
// this would only be for content hosted on the same origin as the riot client: anything
|
// this would only be for content hosted on the same origin as the riot client: anything
|
||||||
|
@ -150,13 +154,28 @@ export default React.createClass({
|
||||||
if (ALLOWED_APP_URL_SCHEMES.indexOf(parsedWidgetUrl.protocol) !== -1) {
|
if (ALLOWED_APP_URL_SCHEMES.indexOf(parsedWidgetUrl.protocol) !== -1) {
|
||||||
safeWidgetUrl = url.format(parsedWidgetUrl);
|
safeWidgetUrl = url.format(parsedWidgetUrl);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
if (this.state.loading) {
|
||||||
|
appTileBody = (
|
||||||
|
<div> Loading... </div>
|
||||||
|
);
|
||||||
|
} else if (this.state.hasPermissionToLoad === true) {
|
||||||
appTileBody = (
|
appTileBody = (
|
||||||
<div className="mx_AppTileBody">
|
<div className="mx_AppTileBody">
|
||||||
<iframe ref="appFrame" src={safeWidgetUrl} allowFullScreen="true"
|
<iframe
|
||||||
|
ref="appFrame"
|
||||||
|
src={safeWidgetUrl}
|
||||||
|
allowFullScreen="true"
|
||||||
sandbox={sandboxFlags}
|
sandbox={sandboxFlags}
|
||||||
></iframe>
|
></iframe>
|
||||||
</div>
|
</div>
|
||||||
);
|
);
|
||||||
|
} else {
|
||||||
|
appTileBody = (
|
||||||
|
<AppPermission
|
||||||
|
url={this.state.widgetUrl}
|
||||||
|
/>
|
||||||
|
);
|
||||||
}
|
}
|
||||||
|
|
||||||
// editing is done in scalar
|
// editing is done in scalar
|
||||||
|
|
Loading…
Reference in New Issue