From 77dbc793863f1733b9b68cf53a923bbc3250b858 Mon Sep 17 00:00:00 2001 From: Michael Telatynski <7t3chguy@gmail.com> Date: Sat, 29 Jun 2019 07:05:43 +0100 Subject: [PATCH] clean up promises properly Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> --- src/SlashCommands.js | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/SlashCommands.js b/src/SlashCommands.js index b554c4117a..07ca61487e 100644 --- a/src/SlashCommands.js +++ b/src/SlashCommands.js @@ -45,7 +45,7 @@ const singleMxcUpload = async () => { Modal.createTrackedDialog('Upload Files confirmation', '', UploadConfirmDialog, { file, onFinished: (shouldContinue) => { - if (shouldContinue) resolve(MatrixClientPeg.get().uploadContent(file)); + resolve(shouldContinue ? MatrixClientPeg.get().uploadContent(file) : null); }, }); }; @@ -246,6 +246,7 @@ export const CommandMap = { } return success(promise.then((url) => { + if (!url) return; const ev = room.currentState.getStateEvents('m.room.member', userId); const content = { ...ev ? ev.getContent() : { membership: 'join' }, @@ -267,6 +268,7 @@ export const CommandMap = { } return success(promise.then((url) => { + if (!url) return; return MatrixClientPeg.get().setAvatarUrl(url); })); },