OpenCloud
/
riot-web
mirror of https://github.com/vector-im/riot-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Cypress: workaround for EventTile being remounted (#10961) 

(Hopefully) fixes https://github.com/vector-im/element-web/issues/25417
pull/28788/head^2
Richard van der Hoff 2023-05-23 11:09:31 +01:00 committed by GitHub
parent f9e99ed302
commit 7c34d66bde
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 23 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
cypress/e2e/audio-player/audio-player.spec.ts
View File

@ -333,30 +333,33 @@ describe("Audio player", () => {
// On a thread // On a thread
cy.get(".mx_ThreadView").within(() => { cy.get(".mx_ThreadView").within(() => {
cy.get(".mx_EventTile_last") cy.get(".mx_EventTile_last").within(() => {
.within(() => { // Assert that the player is correctly rendered on a thread
// Assert that the player is correctly rendered on a thread cy.get(".mx_EventTile_mediaLine .mx_MAudioBody .mx_AudioPlayer_container").within(() => {
cy.get(".mx_EventTile_mediaLine .mx_MAudioBody .mx_AudioPlayer_container").within(() => { // Assert that the counter is zero before clicking the play button
// Assert that the counter is zero before clicking the play button cy.contains(".mx_AudioPlayer_seek [role='timer']", "00:00").should("exist");
cy.contains(".mx_AudioPlayer_seek [role='timer']", "00:00").should("exist");
// Find and click "Play" button, the wait is to make the test less flaky // Find and click "Play" button, the wait is to make the test less flaky
cy.findByRole("button", { name: "Play" }).should("exist"); cy.findByRole("button", { name: "Play" }).should("exist");
cy.wait(500).findByRole("button", { name: "Play" }).click(); cy.wait(500).findByRole("button", { name: "Play" }).click();
// Assert that "Pause" button can be found // Assert that "Pause" button can be found
cy.findByRole("button", { name: "Pause" }).should("exist"); cy.findByRole("button", { name: "Pause" }).should("exist");
// Assert that the timer is reset when the audio file finished playing // Assert that the timer is reset when the audio file finished playing
cy.contains(".mx_AudioPlayer_seek [role='timer']", "00:00").should("exist"); cy.contains(".mx_AudioPlayer_seek [role='timer']", "00:00").should("exist");
// Assert that "Play" button can be found // Assert that "Play" button can be found
cy.findByRole("button", { name: "Play" }).should("exist").should("not.have.attr", "disabled"); cy.findByRole("button", { name: "Play" }).should("exist").should("not.have.attr", "disabled");
}); });
}) });
.realHover()
.findByRole("button", { name: "Reply" }) // Find and click "Reply" button
.click(); // Find and click "Reply" button //
// Calling cy.get(".mx_EventTile_last") again here is a workaround for
// https://github.com/matrix-org/matrix-js-sdk/issues/3394: the event tile may have been re-mounted while
// the audio was playing.
cy.get(".mx_EventTile_last").realHover().findByRole("button", { name: "Reply" }).click();
cy.get(".mx_MessageComposer--compact").within(() => { cy.get(".mx_MessageComposer--compact").within(() => {
// Assert that the reply preview is rendered on the message composer // Assert that the reply preview is rendered on the message composer