OpenCloud
/
riot-web
mirror of https://github.com/vector-im/riot-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Merge pull request #5456 from matrix-org/dbkr/call_ui_height 

Fix height of Remote Video in call
pull/21833/head
David Baker 2020-12-10 13:49:47 +00:00 committed by GitHub
parent f987908d04 026b4422a8
commit 8e66fea7ca
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
res/css/views/voip/_CallView.scss
View File

@ -26,7 +26,8 @@ limitations under the License.
}
.mx_CallView_large {
padding-bottom: 10px;
// XXX: This should be 10 but somehow it's gaining an extra 4px from somewhere...
padding-bottom: 6px;
.mx_CallView_voice {
height: 360px;

8
src/components/views/voip/CallView.tsx
View File

@ -94,6 +94,10 @@ const CONTROLS_HIDE_DELAY = 1000;
// Height of the header duplicated from CSS because we need to subtract it from our max
// height to get the max height of the video
const HEADER_HEIGHT = 44;
// Also duplicated from the CSS: the bottom padding on the call view
const CALL_PADDING_BOTTOM = 10;
const CONTEXT_MENU_VPADDING = 8; // How far the context menu sits above the button (px)
export default class CallView extends React.Component<IProps, IState> {
@ -478,7 +482,9 @@ export default class CallView extends React.Component<IProps, IState> {
}
// if we're fullscreen, we don't want to set a maxHeight on the video element.
const maxVideoHeight = getFullScreenElement() ? null : this.props.maxVideoHeight - HEADER_HEIGHT;
const maxVideoHeight = getFullScreenElement() ? null : (
this.props.maxVideoHeight - HEADER_HEIGHT - CALL_PADDING_BOTTOM
);
contentView = <div className={containerClasses} ref={this.contentRef} onMouseMove={this.onMouseMove}>
{onHoldBackground}
<VideoFeed type={VideoFeedType.Remote} call={this.state.call} onResize={this.props.onResize}