Merge pull request #909 from matrix-org/rav/fix_missing_page_type

Fix 'missing page_type' error
pull/21833/head
Richard van der Hoff 2017-05-19 15:22:18 +01:00 committed by GitHub
commit 8eea8c0fd7
1 changed files with 6 additions and 1 deletions

View File

@ -1171,7 +1171,12 @@ module.exports = React.createClass({
<PostRegistration
onComplete={this.onFinishPostRegistration} />
);
} else if (this.state.loggedIn && this.state.ready) {
}
// `ready` and `loggedIn` may be set before `page_type` (because the
// latter is set via the dispatcher). If we don't yet have a `page_type`,
// keep showing the spinner for now.
if (this.state.loggedIn && this.state.ready && this.state.page_type) {
/* for now, we stuff the entirety of our props and state into the LoggedInView.
* we should go through and figure out what we actually need to pass down, as well
* as using something like redux to avoid having a billion bits of state kicking around.