No need for a set here - bool is fine

pull/21833/head
David Baker 2020-04-28 09:42:39 +01:00
parent 7e956514a2
commit 90326955ba
1 changed files with 4 additions and 3 deletions

View File

@ -200,7 +200,7 @@ export default class DeviceListener {
// as long as cross-signing isn't ready, // as long as cross-signing isn't ready,
// you can't see or dismiss any device toasts // you can't see or dismiss any device toasts
if (crossSigningReady) { if (crossSigningReady) {
const unverifiedDeviceIds = new Set(); const haveUnverifiedDevices = false;
const devices = await cli.getStoredDevicesForUser(cli.getUserId()); const devices = await cli.getStoredDevicesForUser(cli.getUserId());
for (const device of devices) { for (const device of devices) {
@ -208,11 +208,12 @@ export default class DeviceListener {
const deviceTrust = await cli.checkDeviceTrust(cli.getUserId(), device.deviceId); const deviceTrust = await cli.checkDeviceTrust(cli.getUserId(), device.deviceId);
if (!deviceTrust.isCrossSigningVerified() && !this._dismissed.has(device.deviceId)) { if (!deviceTrust.isCrossSigningVerified() && !this._dismissed.has(device.deviceId)) {
unverifiedDeviceIds.add(device.deviceId); haveUnverifiedDevices = true;
break;
} }
} }
if (unverifiedDeviceIds.size > 0) { if (haveUnverifiedDevices) {
ToastStore.sharedInstance().addOrReplaceToast({ ToastStore.sharedInstance().addOrReplaceToast({
key: OTHER_DEVICES_TOAST_KEY, key: OTHER_DEVICES_TOAST_KEY,
title: _t("Review where youre logged in"), title: _t("Review where youre logged in"),