From 946aa7f9799803bbac93f654eced0784e53b5578 Mon Sep 17 00:00:00 2001 From: Travis Ralston Date: Wed, 10 Aug 2022 16:38:53 -0400 Subject: [PATCH] General cleanup of SettingController class (#9170) Noticed while working in the area. --- src/settings/controllers/SettingController.ts | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/settings/controllers/SettingController.ts b/src/settings/controllers/SettingController.ts index a274bcff2c..2d747e5293 100644 --- a/src/settings/controllers/SettingController.ts +++ b/src/settings/controllers/SettingController.ts @@ -63,16 +63,14 @@ export default abstract class SettingController { * @param {String} roomId The room ID, may be null. * @param {*} newValue The new value for the setting, may be null. */ - public onChange(level: SettingLevel, roomId: string, newValue: any) { + public onChange(level: SettingLevel, roomId: string, newValue: any): void { // do nothing by default - - // FIXME: force a fresh on the RoomView for the roomId in question } /** * Gets whether the setting has been disabled due to this controller. */ - public get settingDisabled() { + public get settingDisabled(): boolean { return false; } }