Excluding floating-ui portals as part of hiding tooltips in Playwright screenshots (#28287)

* Excluding floating-ui portals as part of hiding tooltips in Playwright screenshots

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

* Update screenshot

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>

---------

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
pull/28313/head
Michael Telatynski 2024-10-28 11:07:15 +00:00 committed by GitHub
parent ef605260b5
commit 954ff0adc0
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
4 changed files with 3 additions and 9 deletions

View File

@ -196,14 +196,7 @@ export class Helpers {
*/ */
async assertEmptyPinnedMessagesList() { async assertEmptyPinnedMessagesList() {
const rightPanel = this.getRightPanel(); const rightPanel = this.getRightPanel();
await expect(rightPanel).toMatchScreenshot(`pinned-messages-list-empty.png`, { await expect(rightPanel).toMatchScreenshot(`pinned-messages-list-empty.png`);
// hide the tooltip "Room information" to avoid flakiness
css: `
[data-floating-ui-portal] {
display: none !important;
}
`,
});
} }
/** /**

View File

@ -42,7 +42,7 @@ export class Helpers {
*/ */
async assertReleaseAnnouncementIsVisible(name: string) { async assertReleaseAnnouncementIsVisible(name: string) {
await expect(this.getReleaseAnnouncement(name)).toBeVisible(); await expect(this.getReleaseAnnouncement(name)).toBeVisible();
await expect(this.page).toMatchScreenshot(`release-announcement-${name}.png`); await expect(this.page).toMatchScreenshot(`release-announcement-${name}.png`, { showTooltips: true });
} }
/** /**

View File

@ -345,6 +345,7 @@ export const expect = baseExpect.extend({
if (!options?.showTooltips) { if (!options?.showTooltips) {
css += ` css += `
[data-floating-ui-portal],
[role="tooltip"] { [role="tooltip"] {
visibility: hidden !important; visibility: hidden !important;
} }

Binary file not shown.

Before

Width:  |  Height:  |  Size: 18 KiB

After

Width:  |  Height:  |  Size: 17 KiB