From 9a065581e52594f5f069b76c5e74b5d79dcd287a Mon Sep 17 00:00:00 2001
From: Emmanuel <63562663+EECvision@users.noreply.github.com>
Date: Wed, 20 Apr 2022 15:49:12 +0100
Subject: [PATCH] fix rainbow breaks compound emojis (#8245)

* fix rainbow breaks compound emojis

* use lodash split method for text splitting and add a unit test to test the behaviour

* Update _RichText.scss

* Update colour-test.ts
---
 src/utils/colour.ts       |  4 +++-
 test/utils/colour-test.ts | 24 ++++++++++++++++++++++++
 2 files changed, 27 insertions(+), 1 deletion(-)
 create mode 100644 test/utils/colour-test.ts

diff --git a/src/utils/colour.ts b/src/utils/colour.ts
index 10c18dbfe7..96eabd4eb4 100644
--- a/src/utils/colour.ts
+++ b/src/utils/colour.ts
@@ -14,10 +14,12 @@ See the License for the specific language governing permissions and
 limitations under the License.
 */
 
+import { split } from 'lodash';
+
 export function textToHtmlRainbow(str: string): string {
     const frequency = (2 * Math.PI) / str.length;
 
-    return Array.from(str)
+    return split(str, '')
         .map((c, i) => {
             if (c === " ") {
                 return c;
diff --git a/test/utils/colour-test.ts b/test/utils/colour-test.ts
new file mode 100644
index 0000000000..720c34e07b
--- /dev/null
+++ b/test/utils/colour-test.ts
@@ -0,0 +1,24 @@
+/*
+Copyright 2022 Emmanuel Ezeka <eec.studies@gmail.com>
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+import { textToHtmlRainbow } from "../../src/utils/colour";
+
+describe("textToHtmlRainbow", () => {
+    it('correctly transform text to html without splitting the emoji in two', () => {
+        expect(textToHtmlRainbow('🐻')).toBe('<font color="#ff00be">🐻</font>');
+        expect(textToHtmlRainbow('🐕‍🦺')).toBe('<font color="#ff00be">🐕‍🦺</font>');
+    });
+});