Merge pull request #3557 from matrix-org/jryans/scroll-unmount-guard

Abort scroll updates when already unmounted
pull/21833/head
David Baker 2019-10-21 17:05:53 +01:00 committed by GitHub
commit a3dbf881e8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 0 deletions

View File

@ -677,6 +677,11 @@ module.exports = createReactClass({
debuglog("updateHeight getting straight to business, no scrolling going on.");
}
// We might have unmounted since the timer finished, so abort if so.
if (this.unmounted) {
return;
}
const sn = this._getScrollNode();
const itemlist = this.refs.itemlist;
const contentHeight = this._getMessagesHeight();