From af9838408b181665f80f5a143188c1d96be9ba3a Mon Sep 17 00:00:00 2001 From: Matthew Hodgson Date: Wed, 4 May 2016 11:58:37 +0100 Subject: [PATCH] s/devices/notification targets/ --- .../views/settings/Notifications.js | 25 ++++++++----------- 1 file changed, 10 insertions(+), 15 deletions(-) diff --git a/src/components/views/settings/Notifications.js b/src/components/views/settings/Notifications.js index 2f445cadd6..4364da8b0d 100644 --- a/src/components/views/settings/Notifications.js +++ b/src/components/views/settings/Notifications.js @@ -699,7 +699,7 @@ module.exports = React.createClass({ {masterPushRuleDiv}
- All notifications are currently disabled for all devices. + All notifications are currently disabled for all targets.
); @@ -742,13 +742,11 @@ module.exports = React.createClass({ var devicesSection; if (this.state.pushers === undefined) { - devicesSection =
Unable to fetch device list
+ devicesSection =
Unable to fetch notification target list
} else if (this.state.pushers.length == 0) { - devicesSection =
- No devices are receiving push notifications -
+ devicesSection = null; } else { - // It would be great to be able to delete pushers from here too, + // TODO: It would be great to be able to delete pushers from here too, // and this wouldn't be hard to add. var rows = []; for (var i = 0; i < this.state.pushers.length; ++i) { @@ -758,17 +756,17 @@ module.exports = React.createClass({ ); } devicesSection = ( - - - - - - {rows}
ApplicationDevice
); } + if (devicesSection) { + devicesSection = (
+

Notification targets

+ { devicesSection } +
); + } var advancedSettings; if (externalRules.length) { @@ -828,8 +826,6 @@ module.exports = React.createClass({ { emailNotificationsRow } -

General use

-
@@ -850,7 +846,6 @@ module.exports = React.createClass({ { advancedSettings } -

Devices

{ devicesSection }