From afa8b01601b1c9288f907fcf60f2dd3179940d15 Mon Sep 17 00:00:00 2001
From: Suguru Hirahara <luixxiul@users.noreply.github.com>
Date: Wed, 6 Jul 2022 10:48:52 +0000
Subject: [PATCH] Fix headings margin on security user settings tab (#8826)

* Apply kind=link to 'Learn more' link on security user settings tab

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>

* Remove specific margin setting from heading on security user settings tab

Signed-off-by: Suguru Hirahara <luixxiul@users.noreply.github.com>
---
 res/css/views/settings/tabs/_SettingsTab.scss         |  6 ------
 .../settings/tabs/user/_SecurityUserSettingsTab.scss  |  3 ---
 .../settings/tabs/user/SecurityUserSettingsTab.tsx    | 11 ++++++-----
 3 files changed, 6 insertions(+), 14 deletions(-)

diff --git a/res/css/views/settings/tabs/_SettingsTab.scss b/res/css/views/settings/tabs/_SettingsTab.scss
index 49f4282ec5..9d437443cf 100644
--- a/res/css/views/settings/tabs/_SettingsTab.scss
+++ b/res/css/views/settings/tabs/_SettingsTab.scss
@@ -92,12 +92,6 @@ limitations under the License.
     }
 }
 
-.mx_SettingsTab_linkBtn {
-    cursor: pointer;
-    color: $accent;
-    word-break: break-all;
-}
-
 .mx_SettingsTab_toggleWithDescription {
     margin-top: $spacing-24;
 }
diff --git a/res/css/views/settings/tabs/user/_SecurityUserSettingsTab.scss b/res/css/views/settings/tabs/user/_SecurityUserSettingsTab.scss
index ddcf7c11ac..3dad2a49a1 100644
--- a/res/css/views/settings/tabs/user/_SecurityUserSettingsTab.scss
+++ b/res/css/views/settings/tabs/user/_SecurityUserSettingsTab.scss
@@ -27,9 +27,6 @@ limitations under the License.
 }
 
 .mx_SecurityUserSettingsTab {
-    .mx_SettingsTab_heading {
-        margin-bottom: 22px;
-    }
     .mx_SettingsTab_section {
         .mx_AccessibleButton_kind_link {
             font-size: inherit;
diff --git a/src/components/views/settings/tabs/user/SecurityUserSettingsTab.tsx b/src/components/views/settings/tabs/user/SecurityUserSettingsTab.tsx
index a0ae47b8c6..5a950d6535 100644
--- a/src/components/views/settings/tabs/user/SecurityUserSettingsTab.tsx
+++ b/src/components/views/settings/tabs/user/SecurityUserSettingsTab.tsx
@@ -306,11 +306,12 @@ export default class SecurityUserSettingsTab extends React.Component<IProps, ISt
                             { _t("Share anonymous data to help us identify issues. Nothing personal. " +
                                  "No third parties.") }
                         </p>
-                        <p>
-                            <AccessibleButton className="mx_SettingsTab_linkBtn" onClick={onClickAnalyticsLearnMore}>
-                                { _t("Learn more") }
-                            </AccessibleButton>
-                        </p>
+                        <AccessibleButton
+                            kind="link"
+                            onClick={onClickAnalyticsLearnMore}
+                        >
+                            { _t("Learn more") }
+                        </AccessibleButton>
                     </div>
                     { PosthogAnalytics.instance.isEnabled() && (
                         <SettingsFlag