Update code style for ServerConfig components

pull/21833/head
J. Ryan Stinnett 2019-01-28 21:44:41 -06:00
parent 7edd99c48c
commit b0292929ba
2 changed files with 59 additions and 66 deletions

View File

@ -14,8 +14,6 @@ See the License for the specific language governing permissions and
limitations under the License. limitations under the License.
*/ */
'use strict';
import React from 'react'; import React from 'react';
import PropTypes from 'prop-types'; import PropTypes from 'prop-types';
import sdk from '../../../index'; import sdk from '../../../index';
@ -23,16 +21,14 @@ import { _t } from '../../../languageHandler';
const MODULAR_URL = 'https://modular.im/?utm_source=riot-web&utm_medium=web&utm_campaign=riot-web-authentication'; const MODULAR_URL = 'https://modular.im/?utm_source=riot-web&utm_medium=web&utm_campaign=riot-web-authentication';
/** /*
* Configure the Modular server name. * Configure the Modular server name.
* *
* This is a variant of ServerConfig with only the HS field and different body * This is a variant of ServerConfig with only the HS field and different body
* text that is specific to the Modular case. * text that is specific to the Modular case.
*/ */
module.exports = React.createClass({ export default class ModularServerConfig extends React.PureComponent {
displayName: 'ModularServerConfig', static propTypes = {
propTypes: {
onServerConfigChange: PropTypes.func, onServerConfigChange: PropTypes.func,
// default URLs are defined in config.json (or the hardcoded defaults) // default URLs are defined in config.json (or the hardcoded defaults)
@ -53,23 +49,23 @@ module.exports = React.createClass({
customHsUrl: PropTypes.string, customHsUrl: PropTypes.string,
delayTimeMs: PropTypes.number, // time to wait before invoking onChanged delayTimeMs: PropTypes.number, // time to wait before invoking onChanged
}, }
getDefaultProps: function() { static defaultProps = {
return { onServerConfigChange: function() {},
onServerConfigChange: function() {}, customHsUrl: "",
customHsUrl: "", delayTimeMs: 0,
delayTimeMs: 0, }
constructor(props) {
super(props);
this.state = {
hsUrl: props.customHsUrl,
}; };
}, }
getInitialState: function() { componentWillReceiveProps(newProps) {
return {
hsUrl: this.props.customHsUrl,
};
},
componentWillReceiveProps: function(newProps) {
if (newProps.customHsUrl === this.state.hsUrl) return; if (newProps.customHsUrl === this.state.hsUrl) return;
this.setState({ this.setState({
@ -79,9 +75,9 @@ module.exports = React.createClass({
hsUrl: newProps.customHsUrl, hsUrl: newProps.customHsUrl,
isUrl: this.props.defaultIsUrl, isUrl: this.props.defaultIsUrl,
}); });
}, }
onHomeserverChanged: function(ev) { onHomeserverChanged = (ev) => {
this.setState({hsUrl: ev.target.value}, () => { this.setState({hsUrl: ev.target.value}, () => {
this._hsTimeoutId = this._waitThenInvoke(this._hsTimeoutId, () => { this._hsTimeoutId = this._waitThenInvoke(this._hsTimeoutId, () => {
let hsUrl = this.state.hsUrl.trim().replace(/\/$/, ""); let hsUrl = this.state.hsUrl.trim().replace(/\/$/, "");
@ -92,16 +88,16 @@ module.exports = React.createClass({
}); });
}); });
}); });
}, }
_waitThenInvoke: function(existingTimeoutId, fn) { _waitThenInvoke(existingTimeoutId, fn) {
if (existingTimeoutId) { if (existingTimeoutId) {
clearTimeout(existingTimeoutId); clearTimeout(existingTimeoutId);
} }
return setTimeout(fn.bind(this), this.props.delayTimeMs); return setTimeout(fn.bind(this), this.props.delayTimeMs);
}, }
render: function() { render() {
const Field = sdk.getComponent('elements.Field'); const Field = sdk.getComponent('elements.Field');
return ( return (
@ -126,5 +122,5 @@ module.exports = React.createClass({
</div> </div>
</div> </div>
); );
}, }
}); }

View File

@ -15,21 +15,18 @@ See the License for the specific language governing permissions and
limitations under the License. limitations under the License.
*/ */
'use strict'; import React from 'react';
const React = require('react');
import PropTypes from 'prop-types'; import PropTypes from 'prop-types';
const Modal = require('../../../Modal'); import Modal from '../../../Modal';
const sdk = require('../../../index'); import sdk from '../../../index';
import { _t } from '../../../languageHandler'; import { _t } from '../../../languageHandler';
/** /*
* A pure UI component which displays the HS and IS to use. * A pure UI component which displays the HS and IS to use.
*/ */
module.exports = React.createClass({
displayName: 'ServerConfig',
propTypes: { export default class ServerConfig extends React.PureComponent {
static propTypes = {
onServerConfigChange: PropTypes.func, onServerConfigChange: PropTypes.func,
// default URLs are defined in config.json (or the hardcoded defaults) // default URLs are defined in config.json (or the hardcoded defaults)
@ -47,25 +44,25 @@ module.exports = React.createClass({
customIsUrl: PropTypes.string, customIsUrl: PropTypes.string,
delayTimeMs: PropTypes.number, // time to wait before invoking onChanged delayTimeMs: PropTypes.number, // time to wait before invoking onChanged
}, }
getDefaultProps: function() { static defaultProps = {
return { onServerConfigChange: function() {},
onServerConfigChange: function() {}, customHsUrl: "",
customHsUrl: "", customIsUrl: "",
customIsUrl: "", delayTimeMs: 0,
delayTimeMs: 0, }
constructor(props) {
super(props);
this.state = {
hsUrl: props.customHsUrl,
isUrl: props.customIsUrl,
}; };
}, }
getInitialState: function() { componentWillReceiveProps(newProps) {
return {
hsUrl: this.props.customHsUrl,
isUrl: this.props.customIsUrl,
};
},
componentWillReceiveProps: function(newProps) {
if (newProps.customHsUrl === this.state.hsUrl && if (newProps.customHsUrl === this.state.hsUrl &&
newProps.customIsUrl === this.state.isUrl) return; newProps.customIsUrl === this.state.isUrl) return;
@ -77,9 +74,9 @@ module.exports = React.createClass({
hsUrl: newProps.customHsUrl, hsUrl: newProps.customHsUrl,
isUrl: newProps.customIsUrl, isUrl: newProps.customIsUrl,
}); });
}, }
onHomeserverChanged: function(ev) { onHomeserverChanged = (ev) => {
this.setState({hsUrl: ev.target.value}, () => { this.setState({hsUrl: ev.target.value}, () => {
this._hsTimeoutId = this._waitThenInvoke(this._hsTimeoutId, () => { this._hsTimeoutId = this._waitThenInvoke(this._hsTimeoutId, () => {
let hsUrl = this.state.hsUrl.trim().replace(/\/$/, ""); let hsUrl = this.state.hsUrl.trim().replace(/\/$/, "");
@ -90,9 +87,9 @@ module.exports = React.createClass({
}); });
}); });
}); });
}, }
onIdentityServerChanged: function(ev) { onIdentityServerChanged = (ev) => {
this.setState({isUrl: ev.target.value}, () => { this.setState({isUrl: ev.target.value}, () => {
this._isTimeoutId = this._waitThenInvoke(this._isTimeoutId, () => { this._isTimeoutId = this._waitThenInvoke(this._isTimeoutId, () => {
let isUrl = this.state.isUrl.trim().replace(/\/$/, ""); let isUrl = this.state.isUrl.trim().replace(/\/$/, "");
@ -103,21 +100,21 @@ module.exports = React.createClass({
}); });
}); });
}); });
}, }
_waitThenInvoke: function(existingTimeoutId, fn) { _waitThenInvoke(existingTimeoutId, fn) {
if (existingTimeoutId) { if (existingTimeoutId) {
clearTimeout(existingTimeoutId); clearTimeout(existingTimeoutId);
} }
return setTimeout(fn.bind(this), this.props.delayTimeMs); return setTimeout(fn.bind(this), this.props.delayTimeMs);
}, }
showHelpPopup: function() { showHelpPopup = () => {
const CustomServerDialog = sdk.getComponent('auth.CustomServerDialog'); const CustomServerDialog = sdk.getComponent('auth.CustomServerDialog');
Modal.createTrackedDialog('Custom Server Dialog', '', CustomServerDialog); Modal.createTrackedDialog('Custom Server Dialog', '', CustomServerDialog);
}, }
render: function() { render() {
const Field = sdk.getComponent('elements.Field'); const Field = sdk.getComponent('elements.Field');
return ( return (
@ -144,5 +141,5 @@ module.exports = React.createClass({
</div> </div>
</div> </div>
); );
}, }
}); }