OpenCloud
/
riot-web
mirror of https://github.com/vector-im/riot-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Improve strict typing

pull/28788/head^2
Michael Weimann 2023-01-03 10:16:46 +01:00
parent cb4e444a60
commit b79912e390
No known key found for this signature in database
GPG Key ID: 53F535A266BB9584
2 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/Modal.tsx
View File

@ -107,8 +107,8 @@ export class ModalManager extends TypedEventEmitter<ModalManagerEvent, HandlerMa
modal.hidden = !modal.hidden; modal.hidden = !modal.hidden;
} }
public hasDialogs() { public hasDialogs(): boolean {
return this.priorityModal || this.staticModal || this.modals.length > 0; return !!(this.priorityModal || this.staticModal || this.modals.length > 0);
} }
public createDialog<T extends any[]>( public createDialog<T extends any[]>(

14
test/Notifier-test.ts
View File

@ -112,11 +112,11 @@ describe("Notifier", () => {
}); });
mockClient.pushRules = { mockClient.pushRules = {
global: undefined, global: {},
}; };
accountDataEventKey = getLocalNotificationAccountDataEventType(mockClient.deviceId); accountDataEventKey = getLocalNotificationAccountDataEventType(mockClient.deviceId!);
testRoom = new Room(roomId, mockClient, mockClient.getUserId()); testRoom = new Room(roomId, mockClient, mockClient.getSafeUserId());
MockPlatform = mockPlatformPeg({ MockPlatform = mockPlatformPeg({
supportsNotifications: jest.fn().mockReturnValue(true), supportsNotifications: jest.fn().mockReturnValue(true),
@ -127,8 +127,10 @@ describe("Notifier", () => {
Notifier.isBodyEnabled = jest.fn().mockReturnValue(true); Notifier.isBodyEnabled = jest.fn().mockReturnValue(true);
mockClient.getRoom.mockImplementation((id) => { mockClient.getRoom.mockImplementation((id: string | undefined): Room | null => {
return id === roomId ? testRoom : new Room(id, mockClient, mockClient.getUserId()); if (id === roomId) return testRoom;
if (id) return new Room(id, mockClient, mockClient.getSafeUserId());
return null;
}); });
}); });
@ -484,7 +486,7 @@ describe("Notifier", () => {
dis.dispatch<ThreadPayload>({ dis.dispatch<ThreadPayload>({
action: Action.ViewThread, action: Action.ViewThread,
thread_id: rootEvent.getId(), thread_id: rootEvent.getId()!,
}); });
await waitFor(() => expect(SdkContextClass.instance.roomViewStore.getThreadId()).toBe(rootEvent.getId())); await waitFor(() => expect(SdkContextClass.instance.roomViewStore.getThreadId()).toBe(rootEvent.getId()));