From b9eebee13be0b87788c32070e39248316a5e6e38 Mon Sep 17 00:00:00 2001
From: Matthew Hodgson <matthew@matrix.org>
Date: Thu, 4 Apr 2019 16:53:17 +0100
Subject: [PATCH] turn NPE into a throw

---
 src/matrix-to.js | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/matrix-to.js b/src/matrix-to.js
index 99a02dc42d..7223f2e33d 100644
--- a/src/matrix-to.js
+++ b/src/matrix-to.js
@@ -239,9 +239,13 @@ export function makeUserPermalink(userId) {
 export function makeRoomPermalink(roomId) {
     const permalinkBase = `${baseUrl}/#/${roomId}`;
 
+    if (!roomId) {
+        throw new Error("can't permalink a falsey roomId");
+    }
+
     // If the roomId isn't actually a room ID, don't try to list the servers.
     // Aliases are already routable, and don't need extra information.
-    if (!roomId || roomId[0] !== '!') return permalinkBase;
+    if (roomId[0] !== '!') return permalinkBase;
 
     const client = MatrixClientPeg.get();
     const room = client.getRoom(roomId);