OpenCloud
/
riot-web
mirror of https://github.com/vector-im/riot-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Avoid rendering view-message link in RoomKnocksBar unnecessarily (#11598) 

Signed-off-by: Charly Nguyen <charly.nguyen@nordeck.net>
t3chguy/dedup-icons-17oct
Charly Nguyen 2023-09-11 15:33:27 +02:00 committed by GitHub
parent 3c6d8a2a28
commit bb91df1d3c
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 23 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/components/views/rooms/RoomKnocksBar.tsx
View File

@ -112,7 +112,7 @@ export const RoomKnocksBar: VFC<{ room: Room }> = ({ room }) => {
</>
);
names = `${knockMembers[0].name} (${knockMembers[0].userId})`;
link = (
link = knockMembers[0].events.member?.getContent().reason && (
<AccessibleButton
className="mx_RoomKnocksBar_link"
element="a"

15
test/components/views/rooms/RoomKnocksBar-test.tsx
View File

@ -165,7 +165,21 @@ describe("RoomKnocksBar", () => {
expect(screen.getByRole("paragraph")).toHaveTextContent(`${bob.name} (${bob.userId})`);
});
describe("when a knock reason is not provided", () => {
it("does not render a link to open the room settings people tab", () => {
getComponent(room);
expect(screen.queryByRole("button", { name: "View message" })).not.toBeInTheDocument();
});
});
describe("when a knock reason is provided", () => {
it("renders a link to open the room settings people tab", () => {
bob.setMembershipEvent(
new MatrixEvent({
content: { displayname: "Bob", membership: "knock", reason: "some reason" },
type: EventType.RoomMember,
}),
);
getComponent(room);
fireEvent.click(getButton("View message"));
expect(dis.dispatch).toHaveBeenCalledWith({
@ -174,6 +188,7 @@ describe("RoomKnocksBar", () => {
room_id: roomId,
});
});
});
type TestCase = [string, ButtonNames, () => void];
it.each<TestCase>([