From 48a618264abebd394887ad18c3169afaad93b077 Mon Sep 17 00:00:00 2001 From: Michael Telatynski <7t3chguy@gmail.com> Date: Fri, 22 May 2020 23:08:46 +0100 Subject: [PATCH] Replace New Version Bar with a Toast discards the `new_version` dispatch Signed-off-by: Michael Telatynski <7t3chguy@gmail.com> --- src/vector/platform/ElectronPlatform.tsx | 8 ++------ src/vector/platform/WebPlatform.ts | 17 ++++++++++------- 2 files changed, 12 insertions(+), 13 deletions(-) diff --git a/src/vector/platform/ElectronPlatform.tsx b/src/vector/platform/ElectronPlatform.tsx index e071a97330..1a60a7e2db 100644 --- a/src/vector/platform/ElectronPlatform.tsx +++ b/src/vector/platform/ElectronPlatform.tsx @@ -42,6 +42,7 @@ import React from "react"; import {randomString} from "matrix-js-sdk/src/randomstring"; import {Action} from "matrix-react-sdk/src/dispatcher/actions"; import { ActionPayload } from "matrix-react-sdk/src/dispatcher/payloads"; +import { showToast as showUpdateToast } from "matrix-react-sdk/src/toasts/UpdateToast"; const ipcRenderer = window.ipcRenderer; const isMac = navigator.platform.toUpperCase().includes('MAC'); @@ -275,12 +276,7 @@ export default class ElectronPlatform extends VectorBasePlatform { } async onUpdateDownloaded(ev, updateInfo) { - dis.dispatch({ - action: 'new_version', - currentVersion: await this.getAppVersion(), - newVersion: updateInfo, - releaseNotes: updateInfo.releaseNotes, - }); + showUpdateToast(await this.getAppVersion(), updateInfo, updateInfo.releaseNotes); } getHumanReadableName(): string { diff --git a/src/vector/platform/WebPlatform.ts b/src/vector/platform/WebPlatform.ts index d43fe12ff2..48f509107c 100644 --- a/src/vector/platform/WebPlatform.ts +++ b/src/vector/platform/WebPlatform.ts @@ -21,6 +21,7 @@ import request from 'browser-request'; import dis from 'matrix-react-sdk/src/dispatcher/dispatcher'; import { _t } from 'matrix-react-sdk/src/languageHandler'; import {Room} from "matrix-js-sdk/src/models/room"; +import { showToast as showUpdateToast, hideToast as hideUpdateToast } from "matrix-react-sdk/src/toasts/UpdateToast"; import url from 'url'; import UAParser from 'ua-parser-js'; @@ -135,15 +136,17 @@ export default class WebPlatform extends VectorBasePlatform { return this._getVersion().then((ver) => { if (this.runningVersion === null) { this.runningVersion = ver; - } else if (this.runningVersion !== ver) { - dis.dispatch({ - action: 'new_version', - currentVersion: this.runningVersion, - newVersion: ver, - }); - // Return to skip a MatrixChat state update return; } + + if (this.runningVersion !== ver) { + showUpdateToast(this.runningVersion, ver); + // Return to skip a MatrixChat state update + return; + } else { + hideUpdateToast(); + } + return { status: updateCheckStatusEnum.NOTAVAILABLE }; }, (err) => { console.error("Failed to poll for update", err);