add heuristic to compare documents to prevent autocomplete flicker

Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
pull/21833/head
Michael Telatynski 2018-07-16 18:27:06 +01:00
parent f78e3be1eb
commit c7859fed1a
No known key found for this signature in database
GPG Key ID: 3F879DA5AD802A5E
1 changed files with 4 additions and 2 deletions

View File

@ -498,8 +498,10 @@ export default class MessageComposerInput extends React.Component {
}
}
// when selection changes hide the autocomplete
if (!rangeEquals(this.state.editorState.selection, editorState.selection)) {
// when selection changes hide the autocomplete.
// Selection changes when we enter text so use a heuristic to compare documents without doing it recursively
const documentChanged = this.state.editorState.document.text !== editorState.document.text;
if (!documentChanged && !rangeEquals(this.state.editorState.selection, editorState.selection)) {
this.autocomplete.hide();
}