diff --git a/src/Analytics.js b/src/Analytics.js index 9f540e46b3..8eea47ea89 100644 --- a/src/Analytics.js +++ b/src/Analytics.js @@ -57,6 +57,8 @@ function getRedactedUrl() { } const customVariables = { + // The Matomo installation at https://matomo.riot.im is currently configured + // with a limit of 10 custom variables. 'App Platform': { id: 1, expl: _td('The platform you\'re on'), @@ -92,10 +94,10 @@ const customVariables = { expl: _td('Your homeserver\'s URL'), example: 'https://matrix.org', }, - 'Identity Server URL': { + 'Touch Input': { id: 8, - expl: _td('Your identity server\'s URL'), - example: 'https://vector.im', + expl: _td("Whether you're using Riot on a device where touch is the primary input mechanism"), + example: 'false', }, 'Breadcrumbs': { id: 9, @@ -202,6 +204,13 @@ class Analytics { } catch (e) { } this._setVisitVariable('Installed PWA', installedPWA); + let touchInput = "unknown"; + try { + // MDN claims broad support across browsers + touchInput = window.matchMedia('(pointer: coarse)').matches; + } catch (e) { } + this._setVisitVariable('Touch Input', touchInput); + // start heartbeat this._heartbeatIntervalID = window.setInterval(this.ping.bind(this), HEARTBEAT_INTERVAL); } @@ -303,11 +312,9 @@ class Analytics { if (!config.piwik) return; const whitelistedHSUrls = config.piwik.whitelistedHSUrls || []; - const whitelistedISUrls = config.piwik.whitelistedISUrls || []; this._setVisitVariable('User Type', isGuest ? 'Guest' : 'Logged In'); this._setVisitVariable('Homeserver URL', whitelistRedact(whitelistedHSUrls, homeserverUrl)); - this._setVisitVariable('Identity Server URL', whitelistRedact(whitelistedISUrls, identityServerUrl)); } setBreadcrumbs(state) { diff --git a/src/Lifecycle.js b/src/Lifecycle.js index 24bf99ed24..72cd84bfd9 100644 --- a/src/Lifecycle.js +++ b/src/Lifecycle.js @@ -435,7 +435,7 @@ async function _doSetLoggedIn(credentials, clearStorage) { } } - Analytics.setLoggedIn(credentials.guest, credentials.homeserverUrl, credentials.identityServerUrl); + Analytics.setLoggedIn(credentials.guest, credentials.homeserverUrl); if (localStorage) { try { diff --git a/src/i18n/strings/en_EN.json b/src/i18n/strings/en_EN.json index 7ac9f131d3..c1ac0b1434 100644 --- a/src/i18n/strings/en_EN.json +++ b/src/i18n/strings/en_EN.json @@ -11,7 +11,7 @@ "Which officially provided instance you are using, if any": "Which officially provided instance you are using, if any", "Whether or not you're using the Richtext mode of the Rich Text Editor": "Whether or not you're using the Richtext mode of the Rich Text Editor", "Your homeserver's URL": "Your homeserver's URL", - "Your identity server's URL": "Your identity server's URL", + "Whether you're using Riot on a device where touch is the primary input mechanism": "Whether you're using Riot on a device where touch is the primary input mechanism", "Whether or not you're using the 'breadcrumbs' feature (avatars above the room list)": "Whether or not you're using the 'breadcrumbs' feature (avatars above the room list)", "Whether you're using Riot as an installed Progressive Web App": "Whether you're using Riot as an installed Progressive Web App", "e.g. %(exampleValue)s": "e.g. %(exampleValue)s", diff --git a/src/rageshake/submit-rageshake.js b/src/rageshake/submit-rageshake.js index 659a56dffb..091f64bf93 100644 --- a/src/rageshake/submit-rageshake.js +++ b/src/rageshake/submit-rageshake.js @@ -73,6 +73,12 @@ export default async function sendBugReport(bugReportEndpoint, opts) { installedPWA = window.matchMedia('(display-mode: standalone)').matches; } catch (e) { } + let touchInput = "UNKNOWN"; + try { + // MDN claims broad support across browsers + touchInput = window.matchMedia('(pointer: coarse)').matches; + } catch (e) { } + const client = MatrixClientPeg.get(); console.log("Sending bug report."); @@ -83,6 +89,7 @@ export default async function sendBugReport(bugReportEndpoint, opts) { body.append('version', version); body.append('user_agent', userAgent); body.append('installed_pwa', installedPWA); + body.append('touch_input', touchInput); if (client) { body.append('user_id', client.credentials.userId);