From cc9651089e491854d4ec3292a6b3872d9c6d10da Mon Sep 17 00:00:00 2001 From: David Baker Date: Tue, 15 Mar 2022 13:52:22 +0000 Subject: [PATCH] Fix freeze/crash when 1:1 calling (#8057) * Fix freeze/crash when 1:1 calling Don't log call feed objects because they reference the client and it causes the client to get logged too. * Log purpose too --- src/components/views/voip/AudioFeed.tsx | 5 ++++- src/components/views/voip/VideoFeed.tsx | 5 ++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/src/components/views/voip/AudioFeed.tsx b/src/components/views/voip/AudioFeed.tsx index 944ea3ad00..64a33a6926 100644 --- a/src/components/views/voip/AudioFeed.tsx +++ b/src/components/views/voip/AudioFeed.tsx @@ -93,7 +93,10 @@ export default class AudioFeed extends React.Component { // load() explicitly, it shouldn't be a problem. - Dave await element.load(); } catch (e) { - logger.info("Failed to play media element with feed", this.props.feed, e); + logger.info( + `Failed to play media element with feed for userId ` + + `${this.props.feed.userId} with purpose ${this.props.feed.purpose}`, e, + ); } } diff --git a/src/components/views/voip/VideoFeed.tsx b/src/components/views/voip/VideoFeed.tsx index 532a863272..72eb918465 100644 --- a/src/components/views/voip/VideoFeed.tsx +++ b/src/components/views/voip/VideoFeed.tsx @@ -138,7 +138,10 @@ export default class VideoFeed extends React.PureComponent { // load() explicitly, it shouldn't be a problem. - Dave await element.play(); } catch (e) { - logger.info("Failed to play media element with feed", this.props.feed, e); + logger.info( + `Failed to play media element with feed for userId ` + + `${this.props.feed.userId} with purpose ${this.props.feed.purpose}`, e, + ); } }