diff --git a/src/components/views/right_panel/GroupHeaderButtons.tsx b/src/components/views/right_panel/GroupHeaderButtons.tsx index b15a93e5a0..0bbbea78e3 100644 --- a/src/components/views/right_panel/GroupHeaderButtons.tsx +++ b/src/components/views/right_panel/GroupHeaderButtons.tsx @@ -41,11 +41,11 @@ interface IProps {} export default class GroupHeaderButtons extends HeaderButtons { constructor(props: IProps) { super(props, HeaderKind.Group); - this._onMembersClicked = this._onMembersClicked.bind(this); - this._onRoomsClicked = this._onRoomsClicked.bind(this); + this.onMembersClicked = this.onMembersClicked.bind(this); + this.onRoomsClicked = this.onRoomsClicked.bind(this); } - onAction(payload: ActionPayload) { + public onAction(payload: ActionPayload) { super.onAction(payload); if (payload.action === Action.ViewUser) { @@ -70,7 +70,7 @@ export default class GroupHeaderButtons extends HeaderButtons { } } - _onMembersClicked() { + private onMembersClicked() { if (this.state.phase === RightPanelPhases.GroupMemberInfo) { // send the active phase to trigger a toggle this.setPhase(RightPanelPhases.GroupMemberInfo); @@ -80,7 +80,7 @@ export default class GroupHeaderButtons extends HeaderButtons { } } - _onRoomsClicked() { + private onRoomsClicked() { // This toggles for us, if needed this.setPhase(RightPanelPhases.GroupRoomList); } @@ -90,13 +90,13 @@ export default class GroupHeaderButtons extends HeaderButtons { , , ]; diff --git a/src/components/views/right_panel/HeaderButton.tsx b/src/components/views/right_panel/HeaderButton.tsx index 022a993c65..c7cd064184 100644 --- a/src/components/views/right_panel/HeaderButton.tsx +++ b/src/components/views/right_panel/HeaderButton.tsx @@ -45,12 +45,12 @@ export default class HeaderButton extends React.Component { this.onClick = this.onClick.bind(this); } - onClick(_ev: React.KeyboardEvent) { + private onClick() { Analytics.trackEvent(...this.props.analytics); this.props.onClick(); } - render() { + public render() { const classes = classNames({ mx_RightPanel_headerButton: true, mx_RightPanel_headerButton_highlight: this.props.isHighlighted, diff --git a/src/components/views/right_panel/HeaderButtons.tsx b/src/components/views/right_panel/HeaderButtons.tsx index 499fbbd414..8239a52dea 100644 --- a/src/components/views/right_panel/HeaderButtons.tsx +++ b/src/components/views/right_panel/HeaderButtons.tsx @@ -52,21 +52,21 @@ export default class HeaderButtons extends React.Component { }; } - componentDidMount() { + public componentDidMount() { this.storeToken = RightPanelStore.getSharedInstance().addListener(this.onRightPanelUpdate.bind(this)); this.dispatcherRef = dis.register(this.onAction.bind(this)); // used by subclasses } - componentWillUnmount() { + public componentWillUnmount() { if (this.storeToken) this.storeToken.remove(); if (this.dispatcherRef) dis.unregister(this.dispatcherRef); } - onAction(payload) { + public onAction(payload) { // Ignore - intended to be overridden by subclasses } - setPhase(phase: RightPanelPhases, extras?: Partial) { + public setPhase(phase: RightPanelPhases, extras?: Partial) { dis.dispatch({ action: Action.SetRightPanelPhase, phase: phase, @@ -74,7 +74,7 @@ export default class HeaderButtons extends React.Component { }); } - isPhase(phases: string | string[]) { + public isPhase(phases: string | string[]) { if (Array.isArray(phases)) { return phases.includes(this.state.phase); } else { @@ -82,7 +82,7 @@ export default class HeaderButtons extends React.Component { } } - onRightPanelUpdate() { + private onRightPanelUpdate() { const rps = RightPanelStore.getSharedInstance(); if (this.state.headerKind === HeaderKind.Room) { this.setState({phase: rps.visibleRoomPanelPhase}); @@ -92,7 +92,7 @@ export default class HeaderButtons extends React.Component { } // XXX: Make renderButtons a prop - renderButtons(): JSX.Element[] { + public renderButtons(): JSX.Element[] { // Ignore - intended to be overridden by subclasses // Return empty fragment to satisfy the type return [ @@ -101,7 +101,7 @@ export default class HeaderButtons extends React.Component { ]; } - render() { + public render() { // inline style as this will be swapped around in future commits return
{this.renderButtons()} diff --git a/src/components/views/right_panel/RoomHeaderButtons.tsx b/src/components/views/right_panel/RoomHeaderButtons.tsx index 1b3117d67e..636e29443a 100644 --- a/src/components/views/right_panel/RoomHeaderButtons.tsx +++ b/src/components/views/right_panel/RoomHeaderButtons.tsx @@ -41,7 +41,7 @@ export default class RoomHeaderButtons extends HeaderButtons { this.onNotificationsClicked = this.onNotificationsClicked.bind(this); } - onAction(payload: ActionPayload) { + public onAction(payload: ActionPayload) { super.onAction(payload); if (payload.action === Action.ViewUser) { if (payload.member) { @@ -79,7 +79,7 @@ export default class RoomHeaderButtons extends HeaderButtons { this.setPhase(RightPanelPhases.NotificationPanel); } - renderButtons() { + public renderButtons() { return [ ; } - renderVerifiedPhase() { + private renderVerifiedPhase() { const {member, request} = this.props; let text: string; @@ -281,7 +281,7 @@ export default class VerificationPanel extends React.PureComponent