OpenCloud
/
riot-web
mirror of https://github.com/vector-im/riot-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Disable room settings tests

pull/21833/head
Travis Ralston 2019-01-28 14:11:10 -07:00
parent 9513837e97
commit d20bdbbc1a
1 changed files with 192 additions and 191 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

383
test/components/views/rooms/RoomSettings-test.js
View File

@ -1,191 +1,192 @@
import React from 'react'; // TODO: Rewrite room settings tests for dialog support
import ReactDOM from 'react-dom'; // import React from 'react';
import expect from 'expect'; // import ReactDOM from 'react-dom';
import jest from 'jest-mock'; // import expect from 'expect';
import Promise from 'bluebird'; // import jest from 'jest-mock';
import * as testUtils from '../../../test-utils'; // import Promise from 'bluebird';
import sdk from 'matrix-react-sdk'; // import * as testUtils from '../../../test-utils';
const WrappedRoomSettings = testUtils.wrapInMatrixClientContext(sdk.getComponent('views.rooms.RoomSettings')); // import sdk from 'matrix-react-sdk';
import MatrixClientPeg from '../../../../src/MatrixClientPeg'; // const WrappedRoomSettings = testUtils.wrapInMatrixClientContext(sdk.getComponent('views.rooms.RoomSettings'));
import SettingsStore from '../../../../src/settings/SettingsStore'; // import MatrixClientPeg from '../../../../src/MatrixClientPeg';
// import SettingsStore from '../../../../src/settings/SettingsStore';
//
describe('RoomSettings', () => { //
let parentDiv = null; // describe('RoomSettings', () => {
let sandbox = null; // let parentDiv = null;
let client = null; // let sandbox = null;
let roomSettings = null; // let client = null;
const room = testUtils.mkStubRoom('!DdJkzRliezrwpNebLk:matrix.org'); // let roomSettings = null;
// const room = testUtils.mkStubRoom('!DdJkzRliezrwpNebLk:matrix.org');
function expectSentStateEvent(roomId, eventType, expectedEventContent) { //
let found = false; // function expectSentStateEvent(roomId, eventType, expectedEventContent) {
for (const call of client.sendStateEvent.mock.calls) { // let found = false;
const [ // for (const call of client.sendStateEvent.mock.calls) {
actualRoomId, // const [
actualEventType, // actualRoomId,
actualEventContent, // actualEventType,
] = call.slice(0, 3); // actualEventContent,
// ] = call.slice(0, 3);
if (roomId === actualRoomId && actualEventType === eventType) { //
expect(actualEventContent).toEqual(expectedEventContent); // if (roomId === actualRoomId && actualEventType === eventType) {
found = true; // expect(actualEventContent).toEqual(expectedEventContent);
break; // found = true;
} // break;
} // }
expect(found).toBe(true); // }
} // expect(found).toBe(true);
// }
beforeEach(function(done) { //
testUtils.beforeEach(this); // beforeEach(function(done) {
sandbox = testUtils.stubClient(); // testUtils.beforeEach(this);
client = MatrixClientPeg.get(); // sandbox = testUtils.stubClient();
client.credentials = {userId: '@me:domain.com'}; // client = MatrixClientPeg.get();
// client.credentials = {userId: '@me:domain.com'};
client.setRoomName = jest.fn().mockReturnValue(Promise.resolve()); //
client.setRoomTopic = jest.fn().mockReturnValue(Promise.resolve()); // client.setRoomName = jest.fn().mockReturnValue(Promise.resolve());
client.setRoomDirectoryVisibility = jest.fn().mockReturnValue(Promise.resolve()); // client.setRoomTopic = jest.fn().mockReturnValue(Promise.resolve());
// client.setRoomDirectoryVisibility = jest.fn().mockReturnValue(Promise.resolve());
// Covers any room state event (e.g. name, avatar, topic) //
client.sendStateEvent = jest.fn().mockReturnValue(Promise.resolve()); // // Covers any room state event (e.g. name, avatar, topic)
// client.sendStateEvent = jest.fn().mockReturnValue(Promise.resolve());
// Covers room tagging //
client.setRoomTag = jest.fn().mockReturnValue(Promise.resolve()); // // Covers room tagging
client.deleteRoomTag = jest.fn().mockReturnValue(Promise.resolve()); // client.setRoomTag = jest.fn().mockReturnValue(Promise.resolve());
// client.deleteRoomTag = jest.fn().mockReturnValue(Promise.resolve());
// Covers any setting in the SettingsStore //
// (including local client settings not stored via matrix) // // Covers any setting in the SettingsStore
SettingsStore.setValue = jest.fn().mockReturnValue(Promise.resolve()); // // (including local client settings not stored via matrix)
// SettingsStore.setValue = jest.fn().mockReturnValue(Promise.resolve());
parentDiv = document.createElement('div'); //
document.body.appendChild(parentDiv); // parentDiv = document.createElement('div');
// document.body.appendChild(parentDiv);
const gatherWrappedRef = (r) => {roomSettings = r;}; //
// const gatherWrappedRef = (r) => {roomSettings = r;};
// get use wrappedRef because we're using wrapInMatrixClientContext //
ReactDOM.render( // // get use wrappedRef because we're using wrapInMatrixClientContext
<WrappedRoomSettings // ReactDOM.render(
wrappedRef={gatherWrappedRef} // <WrappedRoomSettings
room={room} // wrappedRef={gatherWrappedRef}
/>, // room={room}
parentDiv, // />,
done, // parentDiv,
); // done,
}); // );
// });
afterEach((done) => { //
if (parentDiv) { // afterEach((done) => {
ReactDOM.unmountComponentAtNode(parentDiv); // if (parentDiv) {
parentDiv.remove(); // ReactDOM.unmountComponentAtNode(parentDiv);
parentDiv = null; // parentDiv.remove();
} // parentDiv = null;
sandbox.restore(); // }
done(); // sandbox.restore();
}); // done();
// });
it('should not set when no setting is changed', (done) => { //
roomSettings.save().then(() => { // it('should not set when no setting is changed', (done) => {
expect(client.sendStateEvent).not.toHaveBeenCalled(); // roomSettings.save().then(() => {
expect(client.setRoomTag).not.toHaveBeenCalled(); // expect(client.sendStateEvent).not.toHaveBeenCalled();
expect(client.deleteRoomTag).not.toHaveBeenCalled(); // expect(client.setRoomTag).not.toHaveBeenCalled();
done(); // expect(client.deleteRoomTag).not.toHaveBeenCalled();
}); // done();
}); // });
// });
// XXX: Apparently we do call SettingsStore.setValue //
xit('should not settings via the SettingsStore when no setting is changed', (done) => { // // XXX: Apparently we do call SettingsStore.setValue
roomSettings.save().then(() => { // xit('should not settings via the SettingsStore when no setting is changed', (done) => {
expect(SettingsStore.setValue).not.toHaveBeenCalled(); // roomSettings.save().then(() => {
done(); // expect(SettingsStore.setValue).not.toHaveBeenCalled();
}); // done();
}); // });
// });
it('should set room name when it has changed', (done) => { //
const name = "My Room Name"; // it('should set room name when it has changed', (done) => {
roomSettings.setName(name); // const name = "My Room Name";
// roomSettings.setName(name);
roomSettings.save().then(() => { //
expect(client.setRoomName.mock.calls[0].slice(0, 2)) // roomSettings.save().then(() => {
.toEqual(['!DdJkzRliezrwpNebLk:matrix.org', name]); // expect(client.setRoomName.mock.calls[0].slice(0, 2))
// .toEqual(['!DdJkzRliezrwpNebLk:matrix.org', name]);
done(); //
}); // done();
}); // });
// });
it('should set room topic when it has changed', (done) => { //
const topic = "this is a topic"; // it('should set room topic when it has changed', (done) => {
roomSettings.setTopic(topic); // const topic = "this is a topic";
// roomSettings.setTopic(topic);
roomSettings.save().then(() => { //
expect(client.setRoomTopic.mock.calls[0].slice(0, 2)) // roomSettings.save().then(() => {
.toEqual(['!DdJkzRliezrwpNebLk:matrix.org', topic]); // expect(client.setRoomTopic.mock.calls[0].slice(0, 2))
// .toEqual(['!DdJkzRliezrwpNebLk:matrix.org', topic]);
done(); //
}); // done();
}); // });
// });
it('should set history visibility when it has changed', (done) => { //
const historyVisibility = "translucent"; // it('should set history visibility when it has changed', (done) => {
roomSettings.setState({ // const historyVisibility = "translucent";
history_visibility: historyVisibility, // roomSettings.setState({
}); // history_visibility: historyVisibility,
// });
roomSettings.save().then(() => { //
expectSentStateEvent( // roomSettings.save().then(() => {
"!DdJkzRliezrwpNebLk:matrix.org", // expectSentStateEvent(
"m.room.history_visibility", {history_visibility: historyVisibility}, // "!DdJkzRliezrwpNebLk:matrix.org",
); // "m.room.history_visibility", {history_visibility: historyVisibility},
done(); // );
}); // done();
}); // });
// });
// XXX: Can't test this because we `getRoomDirectoryVisibility` in `componentWillMount` //
xit('should set room directory publicity when set to true', (done) => { // // XXX: Can't test this because we `getRoomDirectoryVisibility` in `componentWillMount`
const isRoomPublished = true; // xit('should set room directory publicity when set to true', (done) => {
roomSettings.setState({ // const isRoomPublished = true;
isRoomPublished, // roomSettings.setState({
}, () => { // isRoomPublished,
roomSettings.save().then(() => { // }, () => {
expect(client.setRoomDirectoryVisibility.calls[0].arguments.slice(0, 2)) // roomSettings.save().then(() => {
.toEqual("!DdJkzRliezrwpNebLk:matrix.org", isRoomPublished ? "public" : "private"); // expect(client.setRoomDirectoryVisibility.calls[0].arguments.slice(0, 2))
done(); // .toEqual("!DdJkzRliezrwpNebLk:matrix.org", isRoomPublished ? "public" : "private");
}); // done();
}); // });
}); // });
// });
it('should set power levels when changed', (done) => { //
roomSettings.onPowerLevelsChanged(42, "invite"); // it('should set power levels when changed', (done) => {
// roomSettings.onPowerLevelsChanged(42, "invite");
roomSettings.save().then(() => { //
expectSentStateEvent( // roomSettings.save().then(() => {
"!DdJkzRliezrwpNebLk:matrix.org", // expectSentStateEvent(
"m.room.power_levels", { invite: 42 }, // "!DdJkzRliezrwpNebLk:matrix.org",
); // "m.room.power_levels", { invite: 42 },
done(); // );
}); // done();
}); // });
// });
it('should set event power levels when changed', (done) => { //
roomSettings.onPowerLevelsChanged(42, "event_levels_m.room.message"); // it('should set event power levels when changed', (done) => {
// roomSettings.onPowerLevelsChanged(42, "event_levels_m.room.message");
roomSettings.save().then(() => { //
// We expect all state events to be set to the state_default (50) // roomSettings.save().then(() => {
// See powerLevelDescriptors in RoomSettings // // We expect all state events to be set to the state_default (50)
expectSentStateEvent( // // See powerLevelDescriptors in RoomSettings
"!DdJkzRliezrwpNebLk:matrix.org", // expectSentStateEvent(
"m.room.power_levels", { // "!DdJkzRliezrwpNebLk:matrix.org",
events: { // "m.room.power_levels", {
'm.room.message': 42, // events: {
'm.room.avatar': 50, // 'm.room.message': 42,
'm.room.name': 50, // 'm.room.avatar': 50,
'm.room.canonical_alias': 50, // 'm.room.name': 50,
'm.room.history_visibility': 50, // 'm.room.canonical_alias': 50,
'm.room.power_levels': 50, // 'm.room.history_visibility': 50,
'm.room.topic': 50, // 'm.room.power_levels': 50,
'im.vector.modular.widgets': 50, // 'm.room.topic': 50,
}, // 'im.vector.modular.widgets': 50,
}, // },
); // },
done(); // );
}); // done();
}); // });
}); // });
// });