Merge pull request #2894 from matrix-org/travis/breadcrumbs/ratelimit

Send breadcrumb updates only when they change
pull/21833/head
Travis Ralston 2019-04-09 09:58:04 -06:00 committed by GitHub
commit daaedb8291
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 8 additions and 5 deletions

View File

@ -94,11 +94,6 @@ export default class RoomBreadcrumbs extends React.Component {
setTimeout(() => this.setState({rooms}), 0);
}
}
const roomIds = rooms.map((r) => r.room.roomId);
if (roomIds.length > 0) {
SettingsStore.setValue("breadcrumb_rooms", null, SettingLevel.ACCOUNT, roomIds);
}
}
onAction(payload) {
@ -252,6 +247,14 @@ export default class RoomBreadcrumbs extends React.Component {
if (this.refs.scroller) {
this.refs.scroller.moveToOrigin();
}
// We don't track room aesthetics (badges, membership, etc) over the wire so we
// don't need to do this elsewhere in the file. Just where we alter the room IDs
// and their order.
const roomIds = rooms.map((r) => r.room.roomId);
if (roomIds.length > 0) {
SettingsStore.setValue("breadcrumb_rooms", null, SettingLevel.ACCOUNT, roomIds);
}
}
_viewRoom(room, index) {