From dd5b9329e4b707ec55e53cf00f8e562ede9cf8ff Mon Sep 17 00:00:00 2001 From: Michael Telatynski <7t3chguy@gmail.com> Date: Wed, 19 Jul 2023 17:03:59 +0100 Subject: [PATCH] Only error log url preview failure if not 404 matrix error (#11297) --- src/components/views/rooms/LinkPreviewGroup.tsx | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/components/views/rooms/LinkPreviewGroup.tsx b/src/components/views/rooms/LinkPreviewGroup.tsx index 9f830fffe2..a51903ef59 100644 --- a/src/components/views/rooms/LinkPreviewGroup.tsx +++ b/src/components/views/rooms/LinkPreviewGroup.tsx @@ -18,6 +18,7 @@ import React, { useContext, useEffect } from "react"; import { MatrixEvent } from "matrix-js-sdk/src/models/event"; import { IPreviewUrlResponse, MatrixClient } from "matrix-js-sdk/src/client"; import { logger } from "matrix-js-sdk/src/logger"; +import { MatrixError } from "matrix-js-sdk/src/matrix"; import { useStateToggle } from "../../../hooks/useStateToggle"; import LinkPreviewWidget from "./LinkPreviewWidget"; @@ -106,7 +107,12 @@ const fetchPreviews = (cli: MatrixClient, links: string[], ts: number): Promise< return [link, preview]; } } catch (error) { - logger.error("Failed to get URL preview: " + error); + if (error instanceof MatrixError && error.httpStatus === 404) { + // Quieten 404 Not found errors, not all URLs can have a preview generated + logger.debug("Failed to get URL preview: ", error); + } else { + logger.error("Failed to get URL preview: ", error); + } } }), ).then((a) => a.filter(Boolean)) as Promise<[string, IPreviewUrlResponse][]>;