OpenCloud
/
riot-web
mirror of https://github.com/vector-im/riot-web
1
0
Fork 0
Code Issues Releases Wiki Activity

Merge pull request #11654 from matrix-org/andybalaam/fix-high-level-flakes 

Fix flake in high-level tests by not using markAsRead
pull/28217/head
Andy Balaam 2023-09-25 12:53:56 +01:00 committed by GitHub
parent 5901920635 4097844fed
commit de250df520
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 11 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
cypress/e2e/read-receipts/high-level.spec.ts
View File

@ -22,6 +22,7 @@ import type { MatrixClient, MatrixEvent } from "matrix-js-sdk/src/matrix";
import { HomeserverInstance } from "../../plugins/utils/homeserver"; import { HomeserverInstance } from "../../plugins/utils/homeserver";
import { import {
assertRead, assertRead,
assertStillRead,
assertUnread, assertUnread,
customEvent, customEvent,
goTo, goTo,
@ -157,18 +158,25 @@ describe("Read receipts", () => {
assertRead(room2); assertRead(room2);
}); });
it("Sending an important event after unimportant ones makes the room unread", () => { it("Sending an important event after unimportant ones makes the room unread", () => {
// Given We have read the important messages
goTo(room1); goTo(room1);
assertRead(room2); assertRead(room2);
receiveMessages(room2, ["Msg1", "Msg2"]); receiveMessages(room2, ["Msg1", "Msg2"]);
assertUnread(room2, 2); assertUnread(room2, 2);
goTo(room2);
markAsRead(room2);
assertRead(room2); assertRead(room2);
goTo(room1);
// When we receive important messages
receiveMessages(room2, [customEvent("org.custom.event", { body: "foobar" })]); receiveMessages(room2, [customEvent("org.custom.event", { body: "foobar" })]);
assertRead(room2);
// Then the room is still read
assertStillRead(room2);
// And when we receive more important ones
receiveMessages(room2, ["Hello"]); receiveMessages(room2, ["Hello"]);
// The room is unread again
assertUnread(room2, 1); assertUnread(room2, 1);
}); });
it.skip("A receipt for the last unimportant event makes the room read, even if all are unimportant", () => {}); it.skip("A receipt for the last unimportant event makes the room read, even if all are unimportant", () => {});