Merge pull request #1872 from matrix-org/matthew/lint-changes

relax lint for jsx-curly-spacing and arrow-parens
pull/21833/head
Matthew Hodgson 2018-05-02 23:33:04 +01:00 committed by GitHub
commit ebfcea8b78
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 2 deletions

View File

@ -51,7 +51,12 @@ module.exports = {
// <Element prop={ consideredError} prop={notConsideredError} /> // <Element prop={ consideredError} prop={notConsideredError} />
// //
// https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/docs/rules/jsx-curly-spacing.md // https://github.com/yannickcr/eslint-plugin-react/blob/HEAD/docs/rules/jsx-curly-spacing.md
"react/jsx-curly-spacing": ["error", {"when": "never", "children": {"when": "always"}}], //
// Disabled for now - if anything we'd like to *enforce* spacing in JSX
// curly brackets for legibility, but in practice it's not clear that the
// consistency particularly improves legibility here. --Matthew
//
// "react/jsx-curly-spacing": ["error", {"when": "never", "children": {"when": "always"}}],
// Assert spacing before self-closing JSX tags, and no spacing before or // Assert spacing before self-closing JSX tags, and no spacing before or
// after the closing slash, and no spacing after the opening bracket of // after the closing slash, and no spacing after the opening bracket of
@ -89,7 +94,6 @@ module.exports = {
"valid-jsdoc": ["warn"], "valid-jsdoc": ["warn"],
"new-cap": ["warn"], "new-cap": ["warn"],
"key-spacing": ["warn"], "key-spacing": ["warn"],
"arrow-parens": ["warn"],
"prefer-const": ["warn"], "prefer-const": ["warn"],
// crashes currently: https://github.com/eslint/eslint/issues/6274 // crashes currently: https://github.com/eslint/eslint/issues/6274