From fdcdd2529e2df08db06d87f315b45790ec4afd0a Mon Sep 17 00:00:00 2001 From: Travis Ralston Date: Wed, 22 Apr 2020 10:58:11 -0600 Subject: [PATCH] Take encrypted message search out of labs Fixes https://github.com/vector-im/riot-web/issues/13262 This is part of the cross-signing shipping master plan. Known issues relating to this feature are: * https://github.com/vector-im/riot-web/issues/12896 * https://github.com/vector-im/riot-web/issues/12385 * https://github.com/vector-im/riot-web/issues/11831 * https://github.com/vector-im/riot-web/issues/11155 In theory, these are issues we're comfortable with shipping as we're already enabling it by default. This just makes it easier on everyone by removing the flag (making it still enabled by default). --- .../settings/tabs/user/SecurityUserSettingsTab.js | 15 ++++++--------- src/indexing/EventIndexPeg.js | 4 ---- src/settings/Settings.js | 6 ------ 3 files changed, 6 insertions(+), 19 deletions(-) diff --git a/src/components/views/settings/tabs/user/SecurityUserSettingsTab.js b/src/components/views/settings/tabs/user/SecurityUserSettingsTab.js index 1cde5d6f87..907e29baa7 100644 --- a/src/components/views/settings/tabs/user/SecurityUserSettingsTab.js +++ b/src/components/views/settings/tabs/user/SecurityUserSettingsTab.js @@ -254,15 +254,12 @@ export default class SecurityUserSettingsTab extends React.Component { ); - let eventIndex; - if (SettingsStore.isFeatureEnabled("feature_event_indexing")) { - eventIndex = ( -
- {_t("Message search")} - -
- ); - } + let eventIndex = ( +
+ {_t("Message search")} + +
+ ); // XXX: There's no such panel in the current cross-signing designs, but // it's useful to have for testing the feature. If there's no interest diff --git a/src/indexing/EventIndexPeg.js b/src/indexing/EventIndexPeg.js index 9aa7e78eda..ae4c14dafd 100644 --- a/src/indexing/EventIndexPeg.js +++ b/src/indexing/EventIndexPeg.js @@ -37,10 +37,6 @@ class EventIndexPeg { * EventIndex was successfully initialized, false otherwise. */ async init() { - if (!SettingsStore.isFeatureEnabled("feature_event_indexing")) { - return false; - } - const indexManager = PlatformPeg.get().getEventIndexingManager(); if (!indexManager) { console.log("EventIndex: Platform doesn't support event indexing, not initializing."); diff --git a/src/settings/Settings.js b/src/settings/Settings.js index 5e57c27c9d..928b1985fa 100644 --- a/src/settings/Settings.js +++ b/src/settings/Settings.js @@ -152,12 +152,6 @@ export const SETTINGS = { supportedLevels: ['device', 'config'], // we shouldn't use LEVELS_FEATURE for non-features, so copy it here. default: true, }, - "feature_event_indexing": { - isFeature: true, - supportedLevels: LEVELS_FEATURE, - displayName: _td("Enable local event indexing and E2EE search (requires restart)"), - default: false, - }, "feature_bridge_state": { isFeature: true, supportedLevels: LEVELS_FEATURE,