OpenCloud
/
riot-web
mirror of https://github.com/vector-im/riot-web
1
0
Fork 0
Code Issues Releases Wiki Activity
12,475 Commits
217 Branches
561 Tags
468 MiB
Commit Graph

12475 Commits (35c9dce241e70a6d8807b3a10ff125589ffeb27b)

Author SHA1 Message Date
Travis Ralston 35c9dce241 Fix browser navigation not working between /home, /login, /register, etc 
All of the anchors were pointed at `#` which, when clicked, would trigger a hash change in the browser. This change races the change made by the screen handling where the screen handling ends up losing. Because the hash is then tracked as empty rather than `#/login` (for example), the state machine considers future changes as no-ops and doesn't do anything with them.

By using `preventDefault` and `stopPropagation` on the anchor click events, we prevent the browser from automatically going to an empty hash, which then means the screen handling isn't racing the browser, and the hash change state machine doesn't no-op.

After applying that fix, going between pages worked great unless you were going from /login to /home. This is because the MatrixChat state machine was now out of sync (a `view` of `LOGIN` but a `page` of `HomePage` - an invalid state). All we have to do here is ensure the right view is used when navigating to the homepage. 

Fixes https://github.com/vector-im/riot-web/issues/4061

Note: the concerns in 4061 about logging out upon entering the view appear to have been solved. Navigating to the login page doesn't obliterate your session, at least in my testing.
 2019-01-03 12:13:41 -07:00
David Baker ad47144355
Merge pull request #2395 from matrix-org/dbkr/merge_develop_experimental 
Merge develop into experimental
 2019-01-03 18:55:56 +00:00
David Baker 982e037822 Fix merge 2019-01-03 18:05:38 +00:00
David Baker 7d161de35b Partial merge of develop to experimental 
Does not include #2336 as the file has been moved out from underneath it:
will do this separately
 2019-01-03 15:02:58 +00:00
J. Ryan Stinnett 00405e7f22 Use Nunito font from the server only 
There are various versions of Nunito in circulation, and some have errors in
their metrics or smaller supported character sets. To ensure all users get the
expected experience, don't allow local copies of Nunito to be used.

Fixes vector-im/riot-web#7959.
 2018-12-31 12:26:35 -06:00
J. Ryan Stinnett 097d6fdede Update room filter focus handling to avoid infinite loop 
The classes on the search box input were changed without updating the focusing
loop in the room filter which used one of these classes as a boundary condition.
This led to a case that could loop forever.

Regressed by #2267.
Fixes vector-im/riot-web#7926.
 2018-12-20 23:09:28 +00:00
J. Ryan Stinnett 7affd5fcff Try fetching more branches for PRs 
Attempt both the PR author's branch and the PR's target branch. This resolves
issues on experimental where we need riot-web to also be experimental.
 2018-12-20 22:58:09 +00:00
Nad Chishtie 418bfbb3dc
Merge pull request #2379 from matrix-org/nadonomy/accent 
Added colour var to all themes
 2018-12-20 17:25:53 +00:00
Nad Chishtie 5723ae6040 Defined $accent-color-alt in all themes 2018-12-20 16:06:02 +00:00
J. Ryan Stinnett 95c739be11
Merge pull request #2378 from matrix-org/nadonomy/colours-and-contrast 
Colour, contrast & legibility improvements
 2018-12-20 14:22:04 +00:00
Nad Chishtie 09bf68b1bd Improved colours. 2018-12-20 12:46:43 +00:00
Nad Chishtie 42c8d43065 Lint. 2018-12-20 11:35:58 +00:00
Nad Chishtie 9b8f07c19f Don't override text colour of selected room in room list. 2018-12-20 11:35:43 +00:00
Nad Chishtie d7473c4f4d Various colour, contrast and legibility improvements. 2018-12-20 11:35:21 +00:00
Nad Chishtie 6c2d2f60cf Polished left left panel. 2018-12-20 11:34:20 +00:00
Nad Chishtie b61aa33e99 Tint input icon. 2018-12-20 11:33:53 +00:00
Bruno Windels ad4991cd8b
Merge pull request #2376 from matrix-org/bwindels/redesignfeedbackdialog 
Redesign: add feedback dialog & button in tag panel
 2018-12-19 12:37:00 +00:00
Bruno Windels f7ed1ff046 avoid buttons being deformed in collapsed state 
unsure what this was doing before,
I suspect the BottomLeftMenu which is gone now.
 2018-12-19 12:59:03 +01:00
Bruno Windels b3a12867a6 remove extra blank lines 2018-12-19 12:56:08 +01:00
Bruno Windels b826b0d998 Add redesign feedback dialog + button in tag panel 2018-12-19 12:27:05 +01:00
Bruno Windels 8b406eab3b
Merge pull request #2371 from matrix-org/bwindels/rmdot 
Redesign: add badge with dot to rm button, to see it catches your eye better
 2018-12-19 09:49:19 +00:00
Bruno Windels c75c482cd0
Merge pull request #2374 from matrix-org/nadonomy/add-icon-fix 
Fix misaligned (+) icon
 2018-12-19 09:34:19 +00:00
Nad Chishtie e09121556d Use a more sane SVG. 2018-12-19 09:28:33 +00:00
Bruno Windels e9ebc05eee
Merge pull request #2373 from matrix-org/nadonomy/gradient-fix 
Avoid 'transparent black' gradients in left panel
 2018-12-18 19:03:35 +00:00
Nad Chishtie a829bc901c Updated CSS syntax to avoid 'transparent black'. 2018-12-18 17:59:46 +00:00
Bruno Windels fc516cac76
Merge pull request #2370 from matrix-org/nadonomy/icons 
Normalised icons
 2018-12-18 17:33:49 +00:00
Bruno Windels 1d43712a8f Merge branch 'experimental' into nadonomy/icons 2018-12-18 18:22:24 +01:00
Bruno Windels 2ad9f45655 add badge with dot to rm button, so it catches your eye better 2018-12-18 17:56:05 +01:00
Nad Chishtie 074c96cd3e First pass of normalising icons. 2018-12-18 16:48:20 +00:00
Bruno Windels 8df139bfab
Merge pull request #2369 from matrix-org/bwindels/rhsdefaultsize 
Redesign: give right panel default width
 2018-12-18 16:20:51 +00:00
Bruno Windels 6653236543
Merge pull request #2368 from matrix-org/bwindels/fixloginfield 
Redesign:  Fix login field looking inline
 2018-12-18 16:19:52 +00:00
Bruno Windels 23f24a987c
Merge pull request #2367 from matrix-org/bwindels/selectqueryonclick 
Redesign: select search query on focus
 2018-12-18 16:19:24 +00:00
Bruno Windels 5e2ee883aa
Merge pull request #2366 from matrix-org/bwindels/fixrhscollapse 
Redesign: fix remaining right panel collapse issues.
 2018-12-18 16:19:02 +00:00
Bruno Windels fd5ad56886 give right panel default width of 350px 2018-12-18 17:12:32 +01:00
Bruno Windels c917b4038b scope default input style rules to MatrixChat 2018-12-18 17:02:48 +01:00
Bruno Windels dd6dd7a4fc select search query on focus 2018-12-18 16:37:37 +01:00
Bruno Windels 4b788fcb7e fix lint 2018-12-18 16:29:31 +01:00
Bruno Windels c0ab74d5f1 reemit view_right_panel_phase when showing rhs, so right tab is active 2018-12-18 16:27:17 +01:00
Bruno Windels 92c598dbcf remove group header expand right panel button 2018-12-18 15:38:15 +01:00
Bruno Windels dafc54c434 don't highlight room header buttons when right panel is collapsed 2018-12-18 15:36:54 +01:00
Bruno Windels a10f0a3267 don't open right panel when switching room again 
a view_right_panel_phase is dispatched by RoomHeaderButtons
on view_room, which was triggering this to show the panel again.

Check the fromHeader flag just like when hiding the panel so
only room header buttons can hide or show the right panel
 2018-12-18 15:33:45 +01:00
Bruno Windels 2cb817ae26 remove dead code (collapse button was removed) 2018-12-18 15:33:28 +01:00
Bruno Windels acba36c975
Merge pull request #2364 from matrix-org/bwindels/fixresizepersistenceandscrollindicator-again 
Redesign: left panel fixes
 2018-12-18 14:23:38 +00:00
Bruno Windels 31c13adaba cleanup: do initialization in componentDidMount instead of render 2018-12-18 15:10:57 +01:00
Bruno Windels 2cda6d8f35 fix empty comment line 2018-12-18 15:06:56 +01:00
Bruno Windels f0a412e721 fix docs 2018-12-18 14:32:46 +01:00
Bruno Windels 12a339fe10 change subroomlist min height, as roomtiles are smaller now 2018-12-18 14:32:26 +01:00
Bruno Windels affe75fd3f make scroll indicator gradient smaller (40px->30px) 2018-12-18 14:31:59 +01:00
Bruno Windels 279521cab4 add id to props for completeness 2018-12-18 14:31:38 +01:00
Bruno Windels e67d9c6d4f forward checkOverflow to AutoHideScrollbar, fix over/underflow detection 
the overflow/underflow events are not always reliable in nooverlay
browsers (FF), so forward the checkOverflow call we need anyway
for the scroll indicator gradients to see if we need to do the
margin trick for the on-hover scrollbar we use in nooverlay browsers.

this fixes on hover jumping in a subroomlist
 2018-12-18 14:29:42 +01:00