d851f2e45f
Fix OpenID requests from widgets
...
Fixes https://github.com/vector-im/riot-web/issues/13131
Widgets can request an OpenID token to authenticate the user when the widget is missing authentication information. A common case for this is the Dimension sticker picker: sometimes the Riot is running in doesn't have the configuration to match the Dimension instance, so Riot rightly refuses to send an auth token to the widget. When this happens, it requests a token through postMessage().
There's a toggle on the permission dialog to remember the setting, which is the widget's security key. As an added measure, the security key generation ensures the widget URL matches as the 'remember this choice' toggle will silently work in the background, and it could be dangerous if the widget's URL changed and Riot secretly allows the widget to identify the user. This check was failing because the WidgetMessaging class was being set up with the rendered URL, which will not match the widget's URL at all. To fix this, we simply use the widget's URL to set up the messaging, which by proxy uses the right URL in calculating the security key.
2020-04-22 00:27:20 -06:00
f54e99c708
Use WidgetType more often to avoid breaking new sticker pickers
...
Turns out that setUserWidget() wasn't updated to take a real WidgetType, but the code in ScalarMessaging thought it did. This leads to integration managers trying to add sticker widgets with an object `type` rather than a string `type`, which doesn't work.
This updates other code paths which call into the various widget classes to use WidgetType more often. The actual code path for fixing widgets is resolved in WidgetUtils for the setUserWidget function body.
2020-04-21 16:01:10 -06:00
fd10ab840e
undo unrelated change
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-21 18:10:47 +01:00
65b3adfbe3
discard propTypes some more
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-21 18:08:01 +01:00
598cf21684
discard propTypes.
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-21 18:01:23 +01:00
b8dd68dda2
wait until cross-signing keys are fetched to show verify button
2020-04-21 18:36:15 +02:00
61c6c8de45
Add a back button to the devtools verifications panel
2020-04-21 16:27:31 +01:00
02ed921d57
Merge pull request #4451 from matrix-org/dbkr/create_secret_storage_handle_load_error
...
Handle load error in create secret storage dialog
2020-04-21 10:27:21 +01:00
bf891c85e8
Enable esModuleInterop and iterate PR
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-21 10:01:05 +01:00
ce65df6a98
Merge remote-tracking branch 'origin/develop' into dbkr/create_secret_storage_handle_load_error
2020-04-21 09:40:44 +01:00
5dca84379f
Merge pull request #4382 from matrix-org/travis/addwidget-improvements
...
Allow iframes and Jitsi URLs in /addwidget
2020-04-21 00:30:46 -06:00
3b245ee678
add more type annotations
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-20 21:05:00 +01:00
8398e83d33
add more type annotations
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-20 20:35:57 +01:00
66d2a67142
deduplicate emojibase loading
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-20 19:17:58 +01:00
5c57b9ab9b
delint
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-20 19:04:55 +01:00
6328a60301
improve member name
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-20 19:02:27 +01:00
fced4ea51e
Convert autocomplete stuff to TypeScript
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-20 19:00:54 +01:00
58c8f2188a
Handle load error in create secret storage dialog
2020-04-20 18:10:23 +01:00
36f154f2b2
Name Jitsi correctly in args
...
Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com>
2020-04-20 09:35:35 -06:00
37bd0f3508
Merge pull request #4379 from matrix-org/travis/moar-jitsi
...
Support m.jitsi-typed widgets as Jitsi widgets
2020-04-20 09:31:23 -06:00
a55698e943
Merge branch 'travis/moar-jitsi' into travis/addwidget-improvements
2020-04-20 09:22:38 -06:00
d8a5ba9b14
Merge branch 'develop' into travis/moar-jitsi
2020-04-20 09:21:48 -06:00
360be14b0e
Merge pull request #4450 from matrix-org/dbkr/devicelistener_wait_until_synced
...
Don't recheck DeviceListener until after initial sync is finished
2020-04-20 15:21:22 +01:00
30a3600874
Merge pull request #4449 from matrix-org/dbkr/buttonplaceholder_classname
...
Fix CSS class in ButtonPlaceholder
2020-04-20 14:39:20 +01:00
2546e23a3e
Don't recheck DeviceListener until after initial sync is finished
...
Each recheck caused a GET to account data to see if the master key
exists if done before the initial sync, which is unnecessary here.
This just makes it wait until the initial sync is done to recheck.
Fixes https://github.com/vector-im/riot-web/issues/13279
2020-04-20 14:36:15 +01:00
50cc44f0c4
Fix CSS class in ButtonPlaceholder
2020-04-20 14:16:34 +01:00
ccc1f1fe37
Merge pull request #4441 from matrix-org/t3chguy/login-tab
...
Password Login make sure tab takes user to password field
2020-04-20 13:57:52 +01:00
c77589c9f7
Merge pull request #4439 from matrix-org/t3chguy/network_dropdown
...
Network Dropdown fix things not scrolling properly
2020-04-20 13:57:42 +01:00
bc5fe12a60
Merge pull request #4448 from matrix-org/t3chguy/imageview
...
ImageView make clicking off it easier
2020-04-20 13:55:20 +01:00
62763650d1
Merge pull request #4443 from matrix-org/t3chguy/cmd_rageshake
...
Add slash command to send a rageshake
2020-04-20 13:51:48 +01:00
4494c6cf2b
ImageView make clicking off it easier
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-20 11:21:51 +01:00
3781bdc975
EventIndex: Add a missing semicolon.
2020-04-20 10:10:16 +02:00
6084c08f34
EventIndex: Filter out events that don't have a propper content value.
2020-04-20 10:05:04 +02:00
a2a6dbc7ee
Merge pull request #4445 from matrix-org/revert-4388-thobyv/make-filepanel-remember-scroll-position
...
Revert "Fix Filepanel scroll position state lost when room is changed"
2020-04-19 19:14:20 -06:00
972baa881b
Revert "Fix Filepanel scroll position state lost when room is changed"
2020-04-19 19:14:08 -06:00
881848b98b
Add modal to confirm that rageshake from cmd was sent
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-19 12:19:31 +01:00
d0410ade5e
i18n
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-19 12:11:40 +01:00
170d10a1a6
Add rageshake slash command
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-19 12:09:07 +01:00
3bc5a0a0b2
Convert submit-rageshake to typescript
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-19 12:06:56 +01:00
c04a8d326e
Merge pull request #4442 from matrix-org/t3chguy/change_seshat_copy
...
Update seshat copy to remove trailing full stop
2020-04-19 11:37:48 +01:00
7fe8894c51
Update seshat copy to remove trailing full stop
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-18 23:16:40 +01:00
b86b42c89f
Password Login make sure tab takes user to password field
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-18 16:18:01 +01:00
a0f704f419
Network Dropdown fix things not scrolling properly
...
Signed-off-by: Michael Telatynski <7t3chguy@gmail.com>
2020-04-18 15:08:15 +01:00
9e7b843f5d
Merge pull request #4388 from ThobyV/thobyv/make-filepanel-remember-scroll-position
...
Fix Filepanel scroll position state lost when room is changed
2020-04-17 15:24:52 -06:00
e0d6fa3f51
Rename ref to timelinePanel
2020-04-17 15:15:51 -06:00
dd444ffa5d
Merge pull request #4436 from matrix-org/travis/e2e-e2e-tests
...
Fix end-to-end tests for end-to-end encryption verification
2020-04-17 15:14:12 -06:00
d910eb4d57
Merge branch 'develop' into thobyv/make-filepanel-remember-scroll-position
2020-04-17 15:10:12 -06:00
432dbab8cb
Fix start chat button variable name
2020-04-17 15:06:59 -06:00
a234cb8a44
Merge pull request #4437 from matrix-org/travis/test-logs
...
Don't explode if the e2e test directory exists when crashing
2020-04-17 14:52:12 -06:00
88b5c3ca84
Don't explode if the e2e test directory exists when crashing
...
This is largely expected in local test environments where the developer probably won't remember to clear out the directory themselves.
2020-04-17 14:39:45 -06:00
Travis Ralston