Commit Graph

15765 Commits (a11deffe5ed2eaaac528508df3f2933c0e6623c5)

Author SHA1 Message Date
Travis Ralston d17ea516cc Minus one log 2019-05-29 15:13:20 +01:00
Travis Ralston fc1ac53ef3 Add some logging for COLR checks 2019-05-29 15:13:20 +01:00
Bruno Windels 686045b46a rewrite HTML>MD conversion,handle (nested) block elements&quotes better
Re-use walkDOMDepthFirst we already had for turning the editor into
a string, which also allows us to detect when leaving a node better,
which is needed to decide how block elements create newline parts
is more centralized and robust manner, more in line with
how html works (consecutive block elements break the line)
instead of hacky special casing from before.

Also, to support every line of MD generated
within a BLOCKQUOTE, the parts an element creates are returned
and then centrally prepended with "> ", instead of passing in
the parts array and doing it in every parse... function.
2019-05-29 14:46:15 +02:00
Bruno Windels b0d87e7e47 allow enterNodeCallback to decide whether to decend into a node 2019-05-29 14:27:36 +02:00
Bruno Windels d34d5f1660
Merge pull request #3038 from matrix-org/bwindels/colr-check-race2
Exclude chrome in ua from safari version check for colr support
2019-05-29 11:56:57 +00:00
J. Ryan Stinnett 7cb90db4e9
Merge pull request #3036 from matrix-org/jryans/revert-3019-release
Revert "Make the timeline less noisy for screen readers (mk II) #3019" for release
2019-05-29 12:31:36 +01:00
Bruno Windels 3793361240 always log on return false 2019-05-29 13:24:46 +02:00
Bruno Windels 26a5bb0dcb exclude chrome in ua from safari version check for colr support 2019-05-29 13:05:59 +02:00
Bruno Windels f61e771f7a
Merge pull request #3034 from matrix-org/bwindels/colr-check-race
fix COLR font check being racy
2019-05-29 10:25:47 +00:00
J. Ryan Stinnett 86cd70b7da
Merge pull request #3037 from matrix-org/jryans/decrypt-font-release
Override font for usercontent download link for release
2019-05-29 11:21:27 +01:00
Bruno Windels 3014180762 fix lint & make regex more robust 2019-05-29 12:17:15 +02:00
Bruno Windels 18697d8ee7
Update src/utils/FontManager.js
Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com>
2019-05-29 10:10:18 +00:00
Bruno Windels 50f477dcd0
Update src/utils/FontManager.js
Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com>
2019-05-29 10:09:10 +00:00
Bruno Windels 66738e2284
Update src/utils/FontManager.js
Co-Authored-By: J. Ryan Stinnett <jryans@gmail.com>
2019-05-29 10:08:59 +00:00
Bruno Windels 5c8e280a45 make sure the check doesn't blow up 2019-05-29 12:03:38 +02:00
Bruno Windels ba54b16275 sniff safari 12, macos 10.14 to support COLR, as safari doesn't wait for the font to load to emit load 2019-05-29 11:59:50 +02:00
Bruno Windels 61ace4baef override font for usercontent download link 2019-05-29 10:47:22 +01:00
J. Ryan Stinnett 84dc2f8429
Merge pull request #3035 from matrix-org/bwindels/decrypted-filesize-font
override font for usercontent download link
2019-05-29 10:45:56 +01:00
J. Ryan Stinnett 5f38eef7b9 Revert "Merge pull request #3019 from matrix-org/travis/sr/fix-timeline"
This reverts commit 9a1a9825b0, reversing
changes made to 62dc83310a.
2019-05-29 10:38:17 +01:00
Bruno Windels a5eca6cf79 override font for usercontent download link 2019-05-29 11:02:38 +02:00
Bruno Windels cf704fd2f1 fix COLR font check being racy
also make sure it doesn't run more than once.
keeping the FF sniffing because missing "extract canvas data" permissions
would still break the check.
2019-05-29 10:11:14 +02:00
J. Ryan Stinnett 9914bac24d
Merge pull request #3033 from matrix-org/jryans/revert-3019
Revert "Make the timeline less noisy for screen readers (mk II) #3019"
2019-05-28 18:26:51 +01:00
J. Ryan Stinnett f0d67e0454 Revert "Merge pull request #3019 from matrix-org/travis/sr/fix-timeline"
This reverts commit 9a1a9825b0, reversing
changes made to 62dc83310a.
2019-05-28 12:22:22 +01:00
Bruno Windels e1d1c8f99c
Merge pull request #2968 from npny/npny/autocomplete-prevent-send-on-enter
Hide autocomplete on Enter key press instead of sending message
2019-05-28 09:17:28 +00:00
Bruno Windels 6b680ff681 fallback to setting caret on line node for empty lines
instead of setting at the end of the editor
2019-05-28 10:34:29 +02:00
Bruno Windels 4fc23022f4 remove all non-first-br nodes on new empty line, not just first one
nextSibling returned null after calling removeNode,
so get the nextSibling first
2019-05-28 10:01:16 +02:00
Bruno Windels afd656ae2c
Merge pull request #3025 from matrix-org/bwindels/edit-keyboard-nav
Message editing: arrow key (up/down) navigation between editable events
2019-05-27 15:12:40 +00:00
Bruno Windels 080a6301b1
Merge pull request #3032 from matrix-org/bwindels/filterreply
Message editing: fix reply text appearing in edit
2019-05-27 15:12:18 +00:00
Bruno Windels f5da8162c1 filter out reply text when editing 2019-05-27 17:04:26 +02:00
Bruno Windels dee24ac27a extract constant 2019-05-27 16:45:26 +02:00
Bruno Windels 651cb8b9a7 lint 2019-05-27 16:43:12 +02:00
Bruno Windels 918de849c7 make sure in the future arrow up/down only goes through own events 2019-05-27 16:41:03 +02:00
Travis Ralston 6174cd2998
Merge pull request #3031 from spantaleev/fix-non-integer-thumb-sizes
Do not try to request thumbnails with non-integer widths
2019-05-27 08:37:22 -06:00
Bruno Windels 25e2c747ed focus main composer after cancel or saving edit 2019-05-27 16:26:21 +02:00
Bruno Windels e193522db1 PR feedback: put findPrev/NextEditableEvent in one function with flag 2019-05-27 16:22:55 +02:00
Slavi Pantaleev 3f60b4336f Do not try to request thumbnails with non-integer widths
Issue described in https://github.com/vector-im/riot-web/issues/9690.

With certain `window.devicePixelRatio` values
(e.g.  `1.5789473684210527`), the calculated thumb width/height
would be a non-integer value.

Passing such values to `client.mxcUrlToHttp()` causes it to
generate URLs to the thumbnail API with non-integer values.
As per the spec, non-integer values are forbidden for that API and a
400 HTTP response is returned (`Query parameter b'width' must be an
integer`).

Fixing matrix-js-sdk's `mxcUrlToHttp()` to sanitize such values
would also be a good idea and likely fix more than just matrix-react-sdk
and riot-web. Still, it feels like matrix-react-sdk should play nice
as well, and not request thumbnails for weird widths/heights.

Signed-off-by: Slavi Pantaleev <slavi@devture.com>
2019-05-27 11:06:10 +03:00
Travis Ralston c30908c380
Merge pull request #3030 from aaronraimist/preserve-strikethrough
Message editing: preserve strikethrough as well
2019-05-24 13:05:14 -06:00
Aaron Raimist fec5abadd6
Message editing: preserve strikethrough as well
Signed-off-by: Aaron Raimist <aaron@raim.ist>
2019-05-24 13:57:09 -05:00
Travis Ralston 04c20b6e68
Merge pull request #3027 from matrix-org/travis/colr-logging
Add some logging for COLR checks
2019-05-24 11:01:07 -06:00
Bruno Windels b2592583c4 maintain caret at current line when position is on newline part 2019-05-24 18:54:29 +02:00
Travis Ralston 093de71ff8 Minus one log 2019-05-24 10:53:24 -06:00
Travis Ralston ef9ef0e654 Add some logging for COLR checks 2019-05-24 10:36:07 -06:00
Bruno Windels cf932e0eab
Merge pull request #3026 from matrix-org/bwindels/tabcompletionfixup
Fixup for tab completion: take part length into account as well
2019-05-24 14:24:25 +00:00
Bruno Windels 8c0b8ff618 take part length into account as well 2019-05-24 15:43:55 +02:00
Bruno Windels 4626581dbe scroll event into view when starting to edit 2019-05-24 15:38:51 +02:00
Bruno Windels 9d6a818591
Merge pull request #3024 from matrix-org/bwindels/autocomplete-tab
Message editing: tab completion
2019-05-24 13:29:10 +00:00
Bruno Windels fbb79e4686 don't navigate to next/prev message when editor has modifications
to prevent losing modifications by accident
2019-05-24 14:46:34 +02:00
Bruno Windels bd3dbd1a89 remove edit history from main composer 2019-05-24 14:42:57 +02:00
Bruno Windels 3591eedcfa move between editable events with arrow keys 2019-05-24 14:42:33 +02:00
Bruno Windels 8926fcb3a6 helper functions to find next & previous editable events in timeline 2019-05-24 14:41:24 +02:00