2b037ee146
If we don't block on SDK builds, then the riot-web build fails due to half-built dependencies. This needs to be done at two levels: the js-sdk because it is used by both the react-sdk and riot-web, and at the react-sdk because riot-web needs it. This means our build process is synchronous for js -> react -> riot, at least for the initial build. This does increase the startup time, particularly because the file watch timer is at 5 seconds. The timer is used to detect a storm of file changes in the underlying SDKs and give the build process some room to compile larger files if needed. The file watcher is accompanied by a "canary signal file" to prevent the build-blocking script from unblocking too early. Both the js and react SDKs build when `npm install` is run, so we ensure that we only listen for the `npm start` build for each SDK. This is all done at the riot level instead of at the individual SDK levels (where we could use a canary file to signal up the stack) because: * babel (used by the js-sdk) doesn't really provide an "end up build" signal * webpack is a bit of a nightmare to get it to behave at times * this blocking approach is really only applicable to riot-web, although may be useful to some other projects. Hopefully that all makes sense. |
||
---|---|---|
.github | ||
docs | ||
electron_app | ||
res | ||
scripts | ||
src | ||
test | ||
.babelrc | ||
.editorconfig | ||
.eslintignore | ||
.eslintrc.js | ||
.gitignore | ||
.modernizr.json | ||
.npmignore | ||
.travis.yml | ||
AUTHORS.rst | ||
CHANGELOG.md | ||
CONTRIBUTING.rst | ||
LICENSE | ||
README.md | ||
config.sample.json | ||
karma.conf.js | ||
package-lock.json | ||
package.json | ||
postcss.config.js | ||
release.sh | ||
release_config.yaml | ||
webpack.config.js |
README.md
Riot
Riot (formerly known as Vector) is a Matrix web client built using the Matrix React SDK (https://github.com/matrix-org/matrix-react-sdk).
Getting Started
The easiest way to test Riot is to just use the hosted copy at https://riot.im/app. The develop branch is continuously deployed by Jenkins at https://riot.im/develop for those who like living dangerously.
To host your own copy of Riot, the quickest bet is to use a pre-built released version of Riot:
- Download the latest version from https://github.com/vector-im/riot-web/releases
- Untar the tarball on your web server
- Move (or symlink) the riot-x.x.x directory to an appropriate name
- If desired, copy
config.sample.json
toconfig.json
and edit it as desired. See below for details. - Enter the URL into your browser and log into Riot!
Releases are signed by PGP, and can be checked against the public key at https://riot.im/packages/keys/riot.asc
Note that Chrome does not allow microphone or webcam access for sites served over http (except localhost), so for working VoIP you will need to serve Riot over https.
Installation Steps for Debian Stretch
- Add the repository to your sources.list using either of the following two options:
- Directly to sources.list:
echo "deb https://riot.im/packages/debian/ stretch main" | sudo tee -a /etc/apt/sources.list
- As a separate entry in sources.list.d:
echo "deb https://riot.im/packages/debian/ stretch main" | sudo tee /etc/apt/sources.list.d/riot.list
- Add the gpg signing key for the riot repository:
curl -s https://riot.im/packages/debian/repo-key.asc | sudo apt-key add -
- Update your package lists:
sudo apt-get update
- Install Riot:
sudo apt-get install riot-web
Important Security Note
We do not recommend running Riot from the same domain name as your Matrix homeserver. The reason is the risk of XSS (cross-site-scripting) vulnerabilities that could occur if someone caused Riot to load and render malicious user generated content from a Matrix API which then had trusted access to Riot (or other apps) due to sharing the same domain.
We have put some coarse mitigations into place to try to protect against this situation, but it's still not good practice to do it in the first place. See https://github.com/vector-im/riot-web/issues/1977 for more details.
The same applies for end-to-end encrypted content, but since this is decrypted on the client, Riot needs a way to supply the decrypted content from a separate origin to the one Riot is hosted on. This currently done with a 'cross origin renderer' which is a small piece of javascript hosted on a different domain. To avoid all Riot installs needing one of these to be set up, riot.im hosts one on usercontent.riot.im which is used by default. See 'config.json' if you'd like to host your own. https://github.com/vector-im/riot-web/issues/6173 tracks progress on replacing this with something better.
Building From Source
Riot is a modular webapp built with modern ES6 and requires a npm build system to build.
- Install or update
node.js
so that yournode
is at least v8.12.0 (andnpm
is at least v5.x). - Clone the repo:
git clone https://github.com/vector-im/riot-web.git
. - Switch to the riot-web directory:
cd riot-web
. - If you're using the
develop
branch then it is recommended to set up a proper development environment ("Setting up a dev environment" below) however one can install the develop versions of the dependencies instead:
Whenever you git pull on riot-web you will also probably need to force an update to these dependencies - the simplest way is to re-run the script, but you can also manually update and rebuild them:scripts/fetch-develop.deps.sh
Or just use https://riot.im/develop - the continuous integration release of the develop branch. (Note that we don't reference the develop versions in git directly due to https://github.com/npm/npm/issues/3055.)cd matrix-js-sdk git pull npm install # re-run to pull in any new dependencies # Depending on your version of npm, npm run build may happen as part of # the npm install above (https://docs.npmjs.com/misc/scripts#prepublish-and-prepare) # If in doubt, run it anyway: npm run build cd ../matrix-react-sdk git pull npm install npm run build
- Install the prerequisites:
npm install
. - Configure the app by copying
config.sample.json
toconfig.json
and modifying it (see below for details). npm run dist
to build a tarball to deploy. Untaring this file will give a version-specific directory containing all the files that need to go on your web server.
Note that npm run dist
is not supported on Windows, so Windows users can run npm run build
, which will build all the necessary files into the webapp
directory. The version of Riot will not appear in Settings without
using the dist script. You can then mount the webapp
directory on your
webserver to actually serve up the app, which is entirely static content.
config.json
You can configure the app by copying config.sample.json
to
config.json
and customising it:
For a good example, see https://riot.im/develop/config.json
default_hs_url
is the default homeserver url.default_is_url
is the default identity server url (this is the server used for verifying third party identifiers like email addresses). If this is blank, registering with an email address, adding an email address to your account, or inviting users via email address will not work. Matrix identity servers are very simple web services which map third party identifiers (currently only email addresses) to matrix IDs: see http://matrix.org/docs/spec/identity_service/unstable.html for more details. Currently the only public matrix identity servers are https://matrix.org and https://vector.im. In future identity servers will be decentralised.features
: Lookup of optional features that may beenable
d,disable
d, or exposed to the user in thelabs
section of settings. The available optional experimental features vary from release to release.brand
: String to pass to your homeserver when configuring email notifications, to let the homeserver know what email template to use when talking to you.integrations_ui_url
: URL to the web interface for the integrations server. The integrations server is not Riot and normally not your Home Server either. The integration server settings may be left blank to disable integrations.integrations_rest_url
: URL to the REST interface for the integrations server.integrations_widgets_urls
: list of URLs to the REST interface for the widget integrations server.bug_report_endpoint_url
: endpoint to send bug reports to (must be running a https://github.com/matrix-org/rageshake server)roomDirectory
: config for the public room directory. This section is optional.roomDirectory.servers
: List of other homeservers' directories to include in the drop down list. Optional.default_theme
: name of theme to use by default (e.g. 'light')update_base_url
(electron app only): HTTPS URL to a web server to download updates from. This should be the path to the directory containingmacos
andwin32
(for update packages, not installer packages).cross_origin_renderer_url
: URL to a static HTML page hosting code to help display encrypted file attachments. This MUST be hosted on a completely separate domain to anything else since it is used to isolate the privileges of file attachments to this domain. Default:https://usercontent.riot.im/v1.html
. This needs to contain v1.html from https://github.com/matrix-org/usercontent/blob/master/v1.htmlpiwik
: an object containing the following properties:url
: The URL of the Piwik instance to use for collecting AnalyticswhitelistedHSUrls
: a list of HS URLs to not redact from the AnalyticswhitelistedISUrls
: a list of IS URLs to not redact from the AnalyticssiteId
: The Piwik Site ID to use when sending Analytics to the Piwik server configured above
teamServerConfig
,teamTokenMap
,referralBaseUrl
: an obsolete precursor to communities with referral tracking; please ignore it.welcomeUserId
: the user ID of a bot to invite whenever users register that can give them a tour
Note that index.html
also has an og:image meta tag that is set to an image
hosted on riot.im. This is the image used if links to your copy of Riot
appear in some websites like Facebook, and indeed Riot itself. This has to be
static in the HTML and an absolute URL (and HTTP rather than HTTPS), so it's
not possible for this to be an option in config.json. If you'd like to change
it, you can build Riot as above, but run
RIOT_OG_IMAGE_URL="http://example.com/logo.png" npm run build
.
Alternatively, you can edit the og:image
meta tag in index.html
directly
each time you download a new version of Riot.
Running as a Desktop app
Riot can also be run as a desktop app, wrapped in electron. You can download a pre-built version from https://riot.im/desktop.html or, if you prefer, build it yourself. Requires Electron >=1.6.0
To run as a desktop app:
-
Follow the instructions in 'Building From Source' above, but run
npm run build
instead ofnpm run dist
(since we don't need the tarball). -
Install electron and run it:
npm install electron npm run electron
To build packages, use electron-builder. This is configured to output:
- dmg + zip for macOS
- exe + nupkg for Windows
- deb for Linux
But this can be customised by editing the
build
section of package.json as per https://github.com/electron-userland/electron-builder/wiki/Options
See https://github.com/electron-userland/electron-builder/wiki/Multi-Platform-Build for dependencies required for building packages for various platforms.
The only platform that can build packages for all three platforms is macOS:
brew install wine --without-x11
brew install mono
brew install gnu-tar
npm install
npm run build:electron
For other packages, use electron-builder manually. For example, to build a package for 64 bit Linux:
- Follow the instructions in 'Building From Source' above
node_modules/.bin/build -l --x64
All electron packages go into electron/dist/
Many thanks to @aviraldg for the initial work on the electron integration.
Other options for running as a desktop app:
- https://github.com/krisak/vector-electron-desktop
- @asdf:matrix.org points out that you can use nativefier and it just works(tm)
sudo npm install nativefier -g
nativefier https://riot.im/app/
Development
Before attempting to develop on Riot you must read the developer guide
for matrix-react-sdk
at https://github.com/matrix-org/matrix-react-sdk, which
also defines the design, architecture and style for Riot too.
The idea of Riot is to be a relatively lightweight "skin" of customisations on
top of the underlying matrix-react-sdk
. matrix-react-sdk
provides both the
higher and lower level React components useful for building Matrix communication
apps using React.
After creating a new component you must run npm run reskindex
to regenerate
the component-index.js
for the app (used in future for skinning).
Please note that Riot is intended to run correctly without access to the public internet. So please don't depend on resources (JS libs, CSS, images, fonts) hosted by external CDNs or servers but instead please package all dependencies into Riot itself.
Setting up a dev environment
Much of the functionality in Riot is actually in the matrix-react-sdk
and
matrix-js-sdk
modules. It is possible to set these up in a way that makes it
easy to track the develop
branches in git and to make local changes without
having to manually rebuild each time.
First clone and build matrix-js-sdk
:
git clone https://github.com/matrix-org/matrix-js-sdk.git
pushd matrix-js-sdk
git checkout develop
popd
Then similarly with matrix-react-sdk
:
git clone https://github.com/matrix-org/matrix-react-sdk.git
pushd matrix-react-sdk
git checkout develop
npm link ../matrix-js-sdk
popd
Finally, build and start Riot itself:
git clone git@github.com:vector-im/riot-web.git
cd riot-web
git checkout develop
npm install
npm link ../matrix-js-sdk
npm link ../matrix-react-sdk
npm start
- Wait a few seconds for the initial build to finish; you should see something like:
Remember, the command will not terminate since it runs the web server and rebuilds source files when they change. This development server also disables caching, so do NOT use it in production.Hash: b0af76309dd56d7275c8 Version: webpack 1.12.14 Time: 14533ms Asset Size Chunks Chunk Names bundle.js 4.2 MB 0 [emitted] main bundle.css 91.5 kB 0 [emitted] main bundle.js.map 5.29 MB 0 [emitted] main bundle.css.map 116 kB 0 [emitted] main + 1013 hidden modules
- Open http://127.0.0.1:8080/ in your browser to see your newly built Riot.
When you make changes to matrix-react-sdk
or matrix-js-sdk
they should be
automatically picked up by webpack and built.
If you add or remove any components from the Riot skin, you will need to rebuild
the skin's index by running, npm run reskindex
.
If any of these steps error with, file table overflow
, you are probably on a mac
which has a very low limit on max open files. Run ulimit -Sn 1024
and try again.
You'll need to do this in each new terminal you open before building Riot.
Running the tests
There are a number of application-level tests in the tests
directory; these
are designed to run in a browser instance under the control of
karma. To run them:
- Make sure you have Chrome installed (a recent version, like 59)
- Make sure you have
matrix-js-sdk
andmatrix-react-sdk
installed and built, as above npm run test
The above will run the tests under Chrome in a headless
mode.
You can also tell karma to run the tests in a loop (every time the source
changes), in an instance of Chrome on your desktop, with npm run test-multi
. This also gives you the option of running the tests in 'debug'
mode, which is useful for stepping through the tests in the developer tools.
Translations
To add a new translation, head to the translating doc.
For a developer guide, see the translating dev doc.
Triaging issues
Issues will be triaged by the core team using the below set of tags.
Tags are meant to be used in combination - e.g.:
- P1 critical bug == really urgent stuff that should be next in the bugfixing todo list
- "release blocker" == stuff which is blocking us from cutting the next release.
- P1 feature type:voip == what VoIP features should we be working on next?
priority: compulsory
- P1: top priority - i.e. pool of stuff which we should be working on next
- P2: still need to fix, but lower than P1
- P3: non-urgent
- P4: interesting idea - bluesky some day
- P5: recorded for posterity/to avoid duplicates. No intention to resolves right now.
bug or feature: compulsory
- bug
- feature
bug severity: compulsory, if bug
- critical - whole app doesn't work
- major - entire feature doesn't work
- minor - partially broken feature (but still usable)
- cosmetic - feature works functionally but UI/UX is broken
types
- type:* - refers to a particular part of the app; used to filter bugs on a given topic - e.g. VOIP, signup, timeline, etc.
additional categories (self-explanatory):
- release blocker
- ui/ux (think of this as cosmetic)
- network (specific to network conditions)
- platform specific
- accessibility
- maintenance
- performance
- i18n
- blocked - whether this issue currently can't be progressed due to outside factors
community engagement
- easy
- hacktoberfest
- bounty? - proposal to be included in a bounty programme
- bounty - included in Status Open Bounty