chg: [metaTemplate] Added endpoint to load template from disk by uuid

src/Controller/MetaTemplatesController.php

@@ -142,6 +142,40 @@ class MetaTemplatesController extends AppController
         }
     }
 
+    /**
+     * Create a new template by loading the template on the disk having the provided UUID.
+     *
+     * @param string $uuid
+     */
+    public function createNewTemplate(string $uuid)
+    {
+        if ($this->request->is('post')) {
+            $result = $this->MetaTemplates->createNewTemplate($uuid);
+            if ($this->ParamHandler->isRest()) {
+                return $this->RestResponse->viewData($result, 'json');
+            } else {
+                if ($result['success']) {
+                    $message = __('The template {0} has been created.', $uuid);
+                } else {
+                    $message = __('The template {0} could not be created.', $uuid);
+                }
+                $this->CRUD->setResponseForController('createNewTemplate', $result['success'], $message, $result['files_processed'], $result['update_errors']);
+                $responsePayload = $this->CRUD->getResponsePayload();
+                if (!empty($responsePayload)) {
+                    return $responsePayload;
+                }
+            }
+        } else {
+            if (!$this->ParamHandler->isRest()) {
+                $this->set('title', __('Create Meta Template'));
+                $this->set('question', __('Are you sure you wish to load the meta template with UUID: {0} in the database', h($uuid)));
+                $this->set('actionName', __('Create template'));
+                $this->set('path', ['controller' => 'meta-templates', 'action' => 'create_new_template', $uuid]);
+                $this->render('/genericTemplates/confirm');
+            }
+        }
+    }
+
     public function getMetaFieldsToUpdate($template_id)
     {
         $metaTemplate = $this->MetaTemplates->get($template_id);
@@ -302,11 +336,15 @@ class MetaTemplatesController extends AppController
 
     public function delete($id)
     {
-        $updateableTemplate = $this->getUpdateStatus($id);
+        $metaTemplate = $this->MetaTemplates->get($id, [
-        if (empty($updateableTemplate['can-be-removed'])) {
+            'contain' => ['MetaTemplateFields']
-            throw MethodNotAllowedException(__('This meta-template cannot be removed'));
+        ]);
+        $templateOnDisk = $this->MetaTemplates->readTemplateFromDisk($metaTemplate->uuid);
+        $templateStatus = $this->MetaTemplates->getStatusForMetaTemplate($templateOnDisk, $metaTemplate);
+        if (empty($templateStatus['can-be-removed'])) {
+            throw new MethodNotAllowedException(__('This meta-template cannot be removed'));
         }
-        $this->set('deletionText', __('The meta-template "{0}" has no meta-field and can be safely removed.', h($updateableTemplate['existing_template']->name)));
+        $this->set('deletionText', __('The meta-template "{0}" has no meta-field and can be safely removed.', h($templateStatus['existing_template']->name)));
         $this->CRUD->delete($id);
         $responsePayload = $this->CRUD->getResponsePayload();
         if (!empty($responsePayload)) {

src/Model/Table/MetaTemplatesTable.php

@@ -191,6 +191,44 @@ class MetaTemplatesTable extends AppTable
         return $results;
     }
 
+    /**
+     * Load the templates stored on the disk update and create the one having the provided UUID in the database
+     * Will do nothing if the UUID is already known
+     *
+     * @param string $uuid
+     * @return array The update result containing potential errors and the successes
+     */
+    public function createNewTemplate(string $uuid): array
+    {
+        $templateOnDisk = $this->readTemplateFromDisk($uuid);
+        $templateStatus = $this->getUpdateStatusForTemplate($templateOnDisk);
+        $errors = [];
+        $updatesErrors = [];
+        $files_processed = [];
+        $savedMetaTemplate = null;
+        $success = false;
+        if (empty($templateStatus['new'])) {
+            $error['message'] = __('Template UUID already exists');
+            $success = true;
+        } else if ($this->isStrategyAllowed(MetaTemplatesTable::UPDATE_STRATEGY_CREATE_NEW)) {
+            $success = $this->saveNewMetaTemplate($templateOnDisk, $errors, $savedMetaTemplate);
+        } else {
+            $errors['message'] = __('Could not create template. Something went wrong.');
+        }
+        if ($success) {
+            $files_processed[] = $templateOnDisk['uuid'];
+        }
+        if (!empty($errors)) {
+            $updatesErrors[] = $errors;
+        }
+        $results = [
+            'update_errors' => $updatesErrors,
+            'files_processed' => $files_processed,
+            'success' => !empty($files_processed),
+        ];
+        return $results;
+    }
+
     /**
      * Load the templates stored on the disk and compute their update status.
      * Only compute the result if an UUID is provided
@@ -741,12 +779,12 @@ class MetaTemplatesTable extends AppTable
         $tmp = $this->save($metaTemplate, [
             'associated' => ['MetaTemplateFields']
         ]);
-        $error = null;
+        if ($tmp === false) {
-        if (empty($tmp)) {
             $errors[] = new UpdateError(false, __('Could not save the template.'), $metaTemplate->getErrors());
+            return false;
         }
         $savedMetaTemplate = $tmp;
-        return !is_null($error);
+        return true;
     }
 
     /**