cerebrate-project
/
cerebrate
mirror of https://github.com/cerebrate-project/cerebrate
1
0
Fork 0
Code Issues Releases Wiki Activity

fix: [component:CRUD] Avoid patching entity if it wasn't modified

pull/89/head
Sami Mokaddem 2022-03-09 12:01:15 +01:00
parent 3e4d0a4544
commit 2289e91aca
No known key found for this signature in database
GPG Key ID: 164C473F627A06FA
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/Controller/Component/CRUDComponent.php
View File

@ -411,14 +411,16 @@ class CRUDComponent extends Component
if (!empty($new_value)) { // update meta_field and attach validation errors if (!empty($new_value)) { // update meta_field and attach validation errors
if (isset($metaFieldsIndex[$meta_field_id])) { if (isset($metaFieldsIndex[$meta_field_id])) {
$index = $metaFieldsIndex[$meta_field_id]; $index = $metaFieldsIndex[$meta_field_id];
$metaFieldsTable->patchEntity($entity->meta_fields[$index], [ if ($entity->meta_fields[$index]->value != $new_value) { // nothing to do, value hasn't changed
'value' => $new_value, 'meta_template_field_id' => $rawMetaTemplateField->id $metaFieldsTable->patchEntity($entity->meta_fields[$index], [
], ['value']); 'value' => $new_value, 'meta_template_field_id' => $rawMetaTemplateField->id
$metaFieldsTable->patchEntity( ], ['value']);
$entity->MetaTemplates[$template_id]->meta_template_fields[$meta_template_field_id]->metaFields[$meta_field_id], $metaFieldsTable->patchEntity(
['value' => $new_value, 'meta_template_field_id' => $rawMetaTemplateField->id], $entity->MetaTemplates[$template_id]->meta_template_fields[$meta_template_field_id]->metaFields[$meta_field_id],
['value'] ['value' => $new_value, 'meta_template_field_id' => $rawMetaTemplateField->id],
); ['value']
);
}
} else { // metafield comes from a second post where the temporary entity has already been created } else { // metafield comes from a second post where the temporary entity has already been created
$metaField = $metaFieldsTable->newEmptyEntity(); $metaField = $metaFieldsTable->newEmptyEntity();
$metaFieldsTable->patchEntity($metaField, [ $metaFieldsTable->patchEntity($metaField, [