cerebrate-project
/
cerebrate
mirror of https://github.com/cerebrate-project/cerebrate
1
0
Fork 0
Code Issues Releases Wiki Activity

chg: [settingTable] Gracefully handle if file not writeable

cli-modification-summary
Sami Mokaddem 2022-02-07 11:11:25 +01:00
parent 14ec995c2b
commit 336dfb091c
No known key found for this signature in database
GPG Key ID: 164C473F627A06FA
1 changed files with 14 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
src/Model/Table/SettingsTable.php
View File

@ -3,6 +3,7 @@ namespace App\Model\Table;
use App\Model\Table\AppTable; use App\Model\Table\AppTable;
use Cake\ORM\Table; use Cake\ORM\Table;
use Cake\Filesystem\File;
use Cake\Core\Configure; use Cake\Core\Configure;
use Cake\Error\Debugger; use Cake\Error\Debugger;
@ -85,6 +86,8 @@ class SettingsTable extends AppTable
if (!empty($setting['afterSave'])) { if (!empty($setting['afterSave'])) {
$this->SettingsProvider->evaluateFunctionForSetting($setting['afterSave'], $setting); $this->SettingsProvider->evaluateFunctionForSetting($setting['afterSave'], $setting);
} }
} else {
$errors[] = __('Could not save settings on disk');
} }
} }
return $errors; return $errors;
@ -129,8 +132,16 @@ class SettingsTable extends AppTable
$settings = $this->readSettings(); $settings = $this->readSettings();
$settings[$name] = $value; $settings[$name] = $value;
$settings = json_encode($settings, JSON_PRETTY_PRINT); $settings = json_encode($settings, JSON_PRETTY_PRINT);
file_put_contents(CONFIG . 'config.json', $settings); $path = CONFIG . 'config.json';
$this->loadSettings(); $file = new File($path);
return true; if ($file->writable()) {
$success = file_put_contents($path, $settings);
if ($success) {
$this->loadSettings();
}
} else {
$success = false;
}
return $success;
} }
} }