chg: [settingsTable] Use settings array for the actual saving in saveSetting
- allows us to modify a value in the processing steps before the value is committed to diskcli-modification-summary
parent
665999b8f4
commit
7834ab3d62
|
@ -72,15 +72,15 @@ class SettingsTable extends AppTable
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
$setting['value'] = $value ?? '';
|
||||||
if (empty($errors) && !empty($setting['beforeSave'])) {
|
if (empty($errors) && !empty($setting['beforeSave'])) {
|
||||||
$setting['value'] = $value ?? '';
|
|
||||||
$beforeSaveResult = $this->SettingsProvider->evaluateFunctionForSetting($setting['beforeSave'], $setting);
|
$beforeSaveResult = $this->SettingsProvider->evaluateFunctionForSetting($setting['beforeSave'], $setting);
|
||||||
if ($beforeSaveResult !== true) {
|
if ($beforeSaveResult !== true) {
|
||||||
$errors[] = $beforeSaveResult;
|
$errors[] = $beforeSaveResult;
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
if (empty($errors)) {
|
if (empty($errors)) {
|
||||||
$saveResult = $this->saveSettingOnDisk($name, $value);
|
$saveResult = $this->saveSettingOnDisk($name, $setting['value']);
|
||||||
if ($saveResult) {
|
if ($saveResult) {
|
||||||
if (!empty($setting['afterSave'])) {
|
if (!empty($setting['afterSave'])) {
|
||||||
$this->SettingsProvider->evaluateFunctionForSetting($setting['afterSave'], $setting);
|
$this->SettingsProvider->evaluateFunctionForSetting($setting['afterSave'], $setting);
|
||||||
|
|
Loading…
Reference in New Issue