chg: [setting] Slight refactoring of search function

templates/Instance/settings.php

@@ -174,7 +174,8 @@ function getResolvableID($sectionName, $panelName=false)
             handleSettingValueChange($input)
         })
 
-        redirectToSettingFromURL()
+        const referencedID = window.location.hash
+        redirectToSetting(referencedID)
     })
 
     function saveSetting(statusNode, $input, settingName, settingValue) {
@@ -262,8 +263,7 @@ function getResolvableID($sectionName, $panelName=false)
         }
     }
 
-    function redirectToSettingFromURL() {
-        const referencedID = window.location.hash
+    function redirectToSetting(referencedID) {
         const $settingToFocus = $(referencedID)
         const pageNavID = $(referencedID).closest('.tab-pane').attr('aria-labelledby')
         const $navController = $(`#${pageNavID}`)

templates/element/Settings/search.php

@@ -26,10 +26,21 @@
                 .on('select2:select', function (e) {
                     const selected = e.params.data
                     const settingPath = selected.setting['setting-path']
+                    const {tabName, IDtoFocus} = getTabAndSettingIDFromPath(settingPath)
+                    showSetting(selected, tabName, IDtoFocus)
+                    $("#search-settings").val(null).trigger('change.select2');
+                })
+    })
+
+    function getTabAndSettingIDFromPath(settingPath) {
         let settingPathTokenized = settingPath.split('.')
         settingPathTokenized = settingPathTokenized.map((elem) => elem.replaceAll(/(\.|\W)/g, '_'))
         const tabName = settingPathTokenized[0]
         const IDtoFocus = 'sp-' + settingPathTokenized.slice(1).join('-')
+        return {tabName: tabName, IDtoFocus: IDtoFocus}
+    }
+
+    function showSetting(selected, tabName, IDtoFocus) {
         const $navController = $('.settings-tabs').find('a.nav-link').filter(function() {
             return $(this).text() == tabName
         })
@@ -46,9 +57,7 @@
                 }).tab('show')
             }
         }
-                    $("#search-settings").val(null).trigger('change.select2');
-                })
-    })
+    }
 
     function settingMatcher(params, data) {
         if (params.term == null || params.term.trim() === '') {