From 8e3e4316fb4e18d2f33df3e59df280d583e84452 Mon Sep 17 00:00:00 2001
From: iglocska <andras.iklody@gmail.com>
Date: Tue, 17 Sep 2024 00:08:49 +0200
Subject: [PATCH] chg: [bookmarks] Make the rendering more lenient to malformed
 content

- fail gracefully rather than throwing 500s
---
 src/Controller/Component/NavigationComponent.php | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/src/Controller/Component/NavigationComponent.php b/src/Controller/Component/NavigationComponent.php
index b758b28..b4c4753 100644
--- a/src/Controller/Component/NavigationComponent.php
+++ b/src/Controller/Component/NavigationComponent.php
@@ -74,8 +74,13 @@ class NavigationComponent extends Component
         $userSettingTable = TableRegistry::getTableLocator()->get('UserSettings');
         $setting = $userSettingTable->getSettingByName($this->request->getAttribute('identity'), 'ui.bookmarks');
         $bookmarks = is_null($setting) ? [] : json_decode($setting->value, true);
-
+        if (empty($bookmarks)) {
+            return [];
+        }
         $links = array_map(function($bookmark) {
+            if (!isset($bookmark['name']) || !isset($bookmark['label']) || !isset($bookmark['url'])) {
+                return [];
+            }
             return [
                 'name' => $bookmark['name'],
                 'label' => $bookmark['label'],