cerebrate-project
/
cerebrate
mirror of https://github.com/cerebrate-project/cerebrate
1
0
Fork 0
Code Issues Releases Wiki Activity

fix: [settings] Fixed missing error when evaluating parent settings

pull/70/head
mokaddem 2021-07-30 08:16:04 +02:00
parent b75cdac42b
commit a82c8fe62b
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/Model/Table/SettingsTable.php
View File

@ -50,7 +50,12 @@ class SettingsTable extends AppTable
$errors = []; $errors = [];
$setting = $this->getSetting($name); $setting = $this->getSetting($name);
$value = $this->normaliseValue($value, $setting); $value = $this->normaliseValue($value, $setting);
if (!empty($setting['beforeSave'])) { if ($setting['type'] == 'select') {
if (!in_array($value, array_keys($setting['options']))) {
$errors[] = __('Invalid option provided');
}
}
if (empty($errors) && !empty($setting['beforeSave'])) {
$setting['value'] = $value ?? ''; $setting['value'] = $value ?? '';
$beforeSaveResult = $this->SettingsProvider->evaluateFunctionForSetting($setting['beforeSave'], $setting); $beforeSaveResult = $this->SettingsProvider->evaluateFunctionForSetting($setting['beforeSave'], $setting);
if ($beforeSaveResult !== true) { if ($beforeSaveResult !== true) {