From 7f9418639ebe24dc4751cba40df1e06a2f9f64fe Mon Sep 17 00:00:00 2001 From: Sami Mokaddem Date: Mon, 20 Dec 2021 15:26:36 +0100 Subject: [PATCH 1/2] fix: [main] Prevent setting listeners if dependencies are not loaded --- webroot/js/main.js | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/webroot/js/main.js b/webroot/js/main.js index caf5d24..c4383ff 100644 --- a/webroot/js/main.js +++ b/webroot/js/main.js @@ -279,10 +279,12 @@ $(document).ready(() => { overloadBSDropdown(); addSupportOfNestedDropdown(); - const debouncedGlobalSearch = debounce(performGlobalSearch, 400) - $('#globalSearch') - .keydown(debouncedGlobalSearch) - .keydown(focusSearchResults); + if (window.debounce) { + const debouncedGlobalSearch = debounce(performGlobalSearch, 400) + $('#globalSearch') + .keydown(debouncedGlobalSearch) + .keydown(focusSearchResults); + } $('.lock-sidebar a.btn-lock-sidebar').click(() => { const $sidebar = $('.sidebar') From 30ec856dc3e871fd75276a54e6f67a6a4cab4cf6 Mon Sep 17 00:00:00 2001 From: Sami Mokaddem Date: Tue, 21 Dec 2021 12:34:37 +0100 Subject: [PATCH 2/2] fix: [local_tool:batchApiAction] Various UI and backend fixes --- src/Controller/LocalToolsController.php | 6 +++++- src/Lib/default/local_tool_connectors/MispConnector.php | 2 +- templates/LocalTools/connector_index.php | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/Controller/LocalToolsController.php b/src/Controller/LocalToolsController.php index 55340f4..a0d31b9 100644 --- a/src/Controller/LocalToolsController.php +++ b/src/Controller/LocalToolsController.php @@ -68,7 +68,11 @@ class LocalToolsController extends AppController foreach ($connections as $connection) { $actionDetails = $this->LocalTools->getActionDetails($actionName); $params['connection'] = $connection; - $tmpResult = $this->LocalTools->action($this->ACL->getUser()['id'], $connection->connector, $actionName, $params, $this->request); + try { + $tmpResult = $this->LocalTools->action($this->ACL->getUser()['id'], $connection->connector, $actionName, $params, $this->request); + } catch (\Exception $e) { + $tmpResult = ['success' => false, 'message' => $e->getMessage(), 'data' => []]; + } $tmpResult['connection'] = $connection; $results[$connection->id] = $tmpResult; $successes += $tmpResult['success'] ? 1 : 0; diff --git a/src/Lib/default/local_tool_connectors/MispConnector.php b/src/Lib/default/local_tool_connectors/MispConnector.php index e84f082..59fd2c7 100644 --- a/src/Lib/default/local_tool_connectors/MispConnector.php +++ b/src/Lib/default/local_tool_connectors/MispConnector.php @@ -819,7 +819,7 @@ class MispConnector extends CommonConnectorTools [ 'field' => 'connection_ids', 'type' => 'hidden', - 'value' => $params['connection_ids'] + 'value' => json_encode($params['connection_ids']) ], [ 'field' => 'method', diff --git a/templates/LocalTools/connector_index.php b/templates/LocalTools/connector_index.php index e14be3b..e6ef205 100644 --- a/templates/LocalTools/connector_index.php +++ b/templates/LocalTools/connector_index.php @@ -155,7 +155,7 @@ echo $this->element('genericElements/IndexTable/index_table', [ tableData ) const $footer = $(modalObject.ajaxApi.statusNode).parent() - modalObject.ajaxApi.statusNode.remove() + modalObject.ajaxApi.options.statusNode.remove() const $cancelButton = $footer.find('button[data-dismiss="modal"]') $cancelButton.text('').removeClass('btn-secondary').addClass('btn-primary') }