cerebrate-project
/
cerebrate
mirror of https://github.com/cerebrate-project/cerebrate
1
0
Fork 0
Code Issues Releases Wiki Activity

chg: [setting] Nicer layout for nested settings

pull/70/head
mokaddem 2021-07-30 14:50:10 +02:00
parent 2a7fc06471
commit aa3d7ec75e
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
templates/Instance/settings.php
View File

@ -92,7 +92,6 @@ function genSection($sectionName, $subSectionSettings, $appView)
{ {
$sectionContent = []; $sectionContent = [];
$sectionContent[] = '<div>'; $sectionContent[] = '<div>';
$sectionContent[] = sprintf('<h2 id="%s">%s</h2>', getResolvableID($sectionName), h($sectionName));
if (isLeaf($subSectionSettings)) { if (isLeaf($subSectionSettings)) {
$panelHTML = $appView->element('Settings/panel', [ $panelHTML = $appView->element('Settings/panel', [
'sectionName' => $sectionName, 'sectionName' => $sectionName,
@ -101,6 +100,9 @@ function genSection($sectionName, $subSectionSettings, $appView)
]); ]);
$sectionContent[] = $panelHTML; $sectionContent[] = $panelHTML;
} else { } else {
if (count($subSectionSettings) > 1) {
$sectionContent[] = sprintf('<h2 id="%s">%s</h2>', getResolvableID($sectionName), h($sectionName));
}
foreach ($subSectionSettings as $panelName => $panelSettings) { foreach ($subSectionSettings as $panelName => $panelSettings) {
if (!empty($panelSettings)) { if (!empty($panelSettings)) {
$panelHTML = $appView->element('Settings/panel', [ $panelHTML = $appView->element('Settings/panel', [
@ -125,9 +127,9 @@ function isLeaf($setting)
function getResolvableID($sectionName, $panelName=false) function getResolvableID($sectionName, $panelName=false)
{ {
$id = sprintf('sp-%s', h($sectionName)); $id = sprintf('sp-%s', preg_replace('/(\.|\W)/', '_', h($sectionName)));
if (!empty($panelName)) { if (!empty($panelName)) {
$id .= '-' . preg_replace('/(\.|\s)/', '_', h($panelName)); $id .= '-' . preg_replace('/(\.|\W)/', '_', h($panelName));
} }
return $id; return $id;
} }