Apply missed suggestions from the review of #16090. (#16263)

* Suggestions from PR

* Newsfile

Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>

---------

Signed-off-by: Olivier Wilkinson (reivilibre) <oliverw@matrix.org>
pull/16264/head
reivilibre 2023-09-06 15:15:56 +00:00 committed by GitHub
parent 35934b02a9
commit 51303035f2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 2 deletions

1
changelog.d/16263.misc Normal file
View File

@ -0,0 +1 @@
Add GCC and GNU Make to the Nix flake development environment so that `ruff` can be compiled.

View File

@ -89,6 +89,7 @@
}) })
# The rust-analyzer language server implementation. # The rust-analyzer language server implementation.
rust-analyzer rust-analyzer
# GCC includes a linker; needed for building `ruff` # GCC includes a linker; needed for building `ruff`
gcc gcc
# Needed for building `ruff` # Needed for building `ruff`
@ -248,8 +249,8 @@
# that the development environment's cc compiler uses may differ from that of the system. # that the development environment's cc compiler uses may differ from that of the system.
# #
# When LD_LIBRARY_PATH is set, system tools will attempt to use the development environment's # When LD_LIBRARY_PATH is set, system tools will attempt to use the development environment's
# libraries. Which, when built against an different glibc version lead, to "version 'GLIBC_X.YY' not # libraries. Which, when built against a different glibc version lead, to "version 'GLIBC_X.YY'
# found" errors. # not found" errors.
enterShell = '' enterShell = ''
unset LD_LIBRARY_PATH unset LD_LIBRARY_PATH
''; '';